Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2047243002: Make use of std::map for profiler code map. (Closed)

Created:
4 years, 6 months ago by alph
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make use of std::map for profiler code map. Committed: https://crrev.com/3282b515e9aaf1ed37c0964b7a29a25aaacf5a2c Cr-Commit-Position: refs/heads/master@{#36898}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -72 lines) Patch
M src/profiler/profile-generator.h View 2 chunks +2 lines, -22 lines 2 comments Download
M src/profiler/profile-generator.cc View 2 chunks +22 lines, -50 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047243002/1
4 years, 6 months ago (2016-06-08 06:37:22 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-08 07:07:06 UTC) #4
alph
ptal
4 years, 6 months ago (2016-06-08 07:14:15 UTC) #6
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2047243002/diff/1/src/profiler/profile-generator.h File src/profiler/profile-generator.h (left): https://codereview.chromium.org/2047243002/diff/1/src/profiler/profile-generator.h#oldcode270 src/profiler/profile-generator.h:270: ~CodeMap(); why no dtor?
4 years, 6 months ago (2016-06-08 15:01:41 UTC) #7
alph
https://codereview.chromium.org/2047243002/diff/1/src/profiler/profile-generator.h File src/profiler/profile-generator.h (left): https://codereview.chromium.org/2047243002/diff/1/src/profiler/profile-generator.h#oldcode270 src/profiler/profile-generator.h:270: ~CodeMap(); On 2016/06/08 15:01:40, jochen wrote: > why no ...
4 years, 6 months ago (2016-06-08 21:48:11 UTC) #8
alph
friendly ping
4 years, 6 months ago (2016-06-09 16:06:48 UTC) #9
lpy
lgtm from my side.
4 years, 6 months ago (2016-06-09 16:59:47 UTC) #10
Yang
lgtm
4 years, 6 months ago (2016-06-10 15:38:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047243002/1
4 years, 6 months ago (2016-06-10 16:07:45 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 16:37:58 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 16:40:31 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3282b515e9aaf1ed37c0964b7a29a25aaacf5a2c
Cr-Commit-Position: refs/heads/master@{#36898}

Powered by Google App Engine
This is Rietveld 408576698