Support using a Mojo message pipe in a ChannelHandle.

ipc/ipc_message_utils_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/ipc_message_utils.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <memory>
 
 #include "base/files/file_path.h"
 #include "base/json/json_reader.h"
+#include "ipc/ipc_channel_handle.h"
 #include "ipc/ipc_message.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace IPC {
 namespace {
 
 // Tests nesting of messages as parameters to other messages.
 TEST(IPCMessageUtilsTest, NestedMessages) {
   int32_t nested_routing = 12;
   uint32_t nested_type = 78;
@@ skipping 104 matching lines @@
 
   base::Pickle pickle;
   IPC::WriteParam(&pickle, value);
 
   base::PickleSizer sizer;
   IPC::GetParamSize(&sizer, value);
 
   EXPECT_EQ(sizer.payload_size(), pickle.payload_size());
 }
 
+TEST(IPCMessageUtilsTest, MojoChannelHandle) {
+  mojo::MessagePipe message_pipe;
+  IPC::ChannelHandle channel_handle(message_pipe.handle0.release());
+
+  IPC::Message message;
+  IPC::WriteParam(&message, channel_handle);
+
+  base::PickleSizer sizer;
+  IPC::GetParamSize(&sizer, channel_handle);
+  EXPECT_EQ(sizer.payload_size(), message.payload_size());
+
+  base::PickleIterator iter(message);
+  IPC::ChannelHandle result_handle;
+  EXPECT_TRUE(IPC::ReadParam(&message, &iter, &result_handle));
+  EXPECT_TRUE(result_handle.name.empty());
+#if defined(OS_POSIX)
+  EXPECT_EQ(result_handle.socket.fd, -1);

[dcheng, 2016/06/27 01:55:32]

EXPECT_EQ(expected, actual) is the convention, I think.

[Anand Mistry (off Chromium), 2016/06/27 02:40:43]

Done.

Funnily enough, I've had a post-it note on my monitor (one of three) for the
past ~7 years that says exactly that.

+#elif defined(OS_WIN)
+  EXPECT_TRUE(result_handle.pipe.handle == NULL);

[dcheng, 2016/06/27 01:55:32]

EXPECT_EQ(nullptr, result_handle.pipe.handle)

[Anand Mistry (off Chromium), 2016/06/27 02:40:43]

Done. But note, the field is a HANDLE and I don't know whether the compiler will
allow this comparison. We'll see how the tryjob fairs. I may need to undo this
if the compiler doesn't allow it.

+#endif
+  EXPECT_EQ(channel_handle.mojo_handle, result_handle.mojo_handle);
+}
+
 }  // namespace
 }  // namespace IPC