Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2047213002: [turbofan] Do strength reduction for ObjectIsSmi based on inputs. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Do strength reduction for ObjectIsSmi based on inputs. Ideally we would have a dedicated MachineRepresentation for Smis during representation selection and use that to properly optimize ObjectIsSmi (and other ObjectIs<Type> predicates), but that will take some time to get that done. So in the meantime we can just do simple (local) strength reduction on ObjectIsSmi to avoid Smi checks in the simplest cases at least. R=jarin@chromium.org Committed: https://crrev.com/c91c39611287475e806cb2aee1f60efd4de035fb Cr-Commit-Position: refs/heads/master@{#36809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M src/compiler/simplified-operator-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M test/unittests/compiler/graph-unittest.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-08 04:42:09 UTC) #1
Jarin
lgtm
4 years, 6 months ago (2016-06-08 05:09:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047213002/1
4 years, 6 months ago (2016-06-08 07:10:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 07:11:50 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 07:13:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c91c39611287475e806cb2aee1f60efd4de035fb
Cr-Commit-Position: refs/heads/master@{#36809}

Powered by Google App Engine
This is Rietveld 408576698