Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2047163002: Move leak_detector_controller to its own directory (Closed)

Created:
4 years, 6 months ago by Simon Que
Modified:
4 years, 6 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, Will Harris
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move leak_detector_controller to its own directory This new directory will hold future code that relates to the leak detector as well. BUG=chromium:615223 TEST=unit tests pass Committed: https://crrev.com/efd3f47e46c337720331c05fe023552ef093718c Cr-Commit-Position: refs/heads/master@{#398648}

Patch Set 1 #

Patch Set 2 : Fix include guard path #

Patch Set 3 : Update include paths #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -437 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chromeos_metrics_provider.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/metrics/leak_detector/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/metrics/leak_detector/leak_detector_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/metrics/leak_detector/leak_detector_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/metrics/leak_detector_controller.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/metrics/leak_detector_controller.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/browser/metrics/leak_detector_controller_unittest.cc View 1 chunk +0 lines, -254 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Simon Que
4 years, 6 months ago (2016-06-08 00:29:35 UTC) #2
Ilya Sherman
LGTM, thanks.
4 years, 6 months ago (2016-06-08 02:45:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047163002/40001
4 years, 6 months ago (2016-06-08 02:46:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/196819)
4 years, 6 months ago (2016-06-08 02:53:53 UTC) #7
Simon Que
+jochen to review changes to chrome/*.gypi and chrome/browser/BUILD.gn
4 years, 6 months ago (2016-06-08 04:08:35 UTC) #9
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-08 14:56:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047163002/40001
4 years, 6 months ago (2016-06-08 19:53:27 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-08 20:05:05 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 20:06:58 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/efd3f47e46c337720331c05fe023552ef093718c
Cr-Commit-Position: refs/heads/master@{#398648}

Powered by Google App Engine
This is Rietveld 408576698