Issue 204713003: android_run_skia: fix error check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204713003: android_run_skia: fix error check (Closed)

Created:
6 years, 9 months ago by epoger

Modified:
6 years, 9 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

android_run_skia: fix error check (SkipBuildbotRuns) BUG=skia:2313 NOTREECHECKS=True NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=13881

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	platform_tools/android/bin/android_run_skia	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

epoger

ready for review https://codereview.chromium.org/204713003/diff/1/platform_tools/android/bin/android_run_skia File platform_tools/android/bin/android_run_skia (right): https://codereview.chromium.org/204713003/diff/1/platform_tools/android/bin/android_run_skia#newcode45 platform_tools/android/bin/android_run_skia:45: if [ $'0\r' != "${EXIT_CODE}" ]; ...

6 years, 9 months ago (2014-03-20 19:44:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/204713003/1

6 years, 9 months ago (2014-03-20 19:48:09 UTC) #4

Message was sent while issue was closed.

Change committed as 13881

Expand Messages | Collapse Messages