Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2047123002: Move code that sends an isolate shutdown message to the service isolate to the block after we trans… (Closed)

Created:
4 years, 6 months ago by siva
Modified:
4 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move code that sends an isolate shutdown message to the service isolate to the block after we transition the thread state to ThreadInVM. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/6b9581e228f7009b7101d598a46d09b03441a8f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M runtime/vm/dart.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 6 months ago (2016-06-07 21:52:11 UTC) #2
Cutch
lgtm
4 years, 6 months ago (2016-06-07 21:53:19 UTC) #3
siva
4 years, 6 months ago (2016-06-08 00:04:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6b9581e228f7009b7101d598a46d09b03441a8f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698