Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2047113002: [Android] Make @DisableIf.Build work on classes. (Closed)

Created:
4 years, 6 months ago by jbudorick
Modified:
4 years, 6 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Make @DisableIf.Build work on classes. BUG=617777 Committed: https://crrev.com/59ac9ed65adfc78b82a4d6b7f5810359f922ddb4 Cr-Commit-Position: refs/heads/master@{#398411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -27 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java View 17 chunks +1 line, -21 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java View 2 chunks +1 line, -6 lines 0 comments Download
M base/test/android/junit/src/org/chromium/base/test/util/DisableIfTest.java View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbudorick
4 years, 6 months ago (2016-06-07 21:44:11 UTC) #2
boliu
lgtm
4 years, 6 months ago (2016-06-07 21:50:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047113002/1
4 years, 6 months ago (2016-06-07 21:51:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 23:24:01 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 23:25:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59ac9ed65adfc78b82a4d6b7f5810359f922ddb4
Cr-Commit-Position: refs/heads/master@{#398411}

Powered by Google App Engine
This is Rietveld 408576698