Issue 2047103002: Don't prevent 'isCycleFree' updating for resynthesized constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2047103002: Don't prevent 'isCycleFree' updating for resynthesized constructors. (Closed)

Created:
4 years, 6 months ago by scheglov

Modified:
4 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't prevent 'isCycleFree' updating for resynthesized constructors. We update it in ConstantEvaluationEngine which in general case does not know whether the constructor is resynthesized or not. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0f061f1987061f5cc6e16b1d0f9bcae532c5360e

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	pkg/analyzer/lib/src/dart/element/element.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Brian Wilkerson

lgtm, but it would be good to add a comment explaining why this one method ...

4 years, 6 months ago (2016-06-07 22:09:06 UTC) #2

scheglov

4 years, 6 months ago (2016-06-08 02:21:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0f061f1987061f5cc6e16b1d0f9bcae532c5360e (presubmit successful).