Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2047093004: [css-grid] Fix definite/indefinite size detection for abspos elements (Closed)

Created:
4 years, 6 months ago by Manuel Rego
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-height-definite
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Fix definite/indefinite size detection for abspos elements LayoutBox::percentageLogicalHeightIsResolvable() was not working fine to check if a positioned grid container has definite/indefinite height. The positioned grid container only has definite height when it has a fixed height or the offset properties (top and bottom) are non-auto. The patch fixes LayoutBox::computePercentageLogicalHeight() to take this into account for grid items too. BUG=538513 TEST=fast/css-grid-layout/flex-item-grid-container-percentage-rows.html Committed: https://crrev.com/d9d2d58cf4978b88d19d5647040354a21ea6979b Cr-Commit-Position: refs/heads/master@{#398728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/css-grid-layout/positioned-grid-container-percentage-tracks.html View 1 chunk +108 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Manuel Rego
This has been extracted from: https://codereview.chromium.org/2037383002/
4 years, 6 months ago (2016-06-08 20:40:11 UTC) #2
cbiesinger
lgtm
4 years, 6 months ago (2016-06-08 20:52:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047093004/1
4 years, 6 months ago (2016-06-08 22:10:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 23:17:45 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 23:20:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9d2d58cf4978b88d19d5647040354a21ea6979b
Cr-Commit-Position: refs/heads/master@{#398728}

Powered by Google App Engine
This is Rietveld 408576698