Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2047053002: Moves ash/accessibility_delegate into common (Closed)

Created:
4 years, 6 months ago by sky
Modified:
4 years, 6 months ago
Reviewers:
James Cook
CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, derat+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves ash/accessibility_delegate into common And the default implementation. BUG=581868 TEST=none R=jamescook@chromium.org TBR=jamescook@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5a437a4b7b5131d913327804bd4cedb09f38548d Cr-Commit-Position: refs/heads/master@{#398402}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -426 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/spoken_feedback_toggler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/spoken_feedback_toggler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/accessibility_delegate.h View 1 chunk +0 lines, -136 lines 0 comments Download
M ash/ash.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/ash_touch_exploration_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/audio/sounds.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/accessibility_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/default_accessibility_delegate.h View 2 chunks +4 lines, -5 lines 0 comments Download
A + ash/common/default_accessibility_delegate.cc View 3 chunks +7 lines, -14 lines 0 comments Download
D ash/default_accessibility_delegate.h View 1 chunk +0 lines, -78 lines 0 comments Download
D ash/default_accessibility_delegate.cc View 1 chunk +0 lines, -164 lines 0 comments Download
M ash/keyboard/keyboard_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/ime/tray_ime_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray_accessibility.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray_accessibility.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/sysui/shell_delegate_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_state_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/volume_controller_browsertest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sky
TBR as this is a move (with a git cl format)
4 years, 6 months ago (2016-06-07 20:21:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047053002/1
4 years, 6 months ago (2016-06-07 20:32:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047053002/20001
4 years, 6 months ago (2016-06-07 21:03:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 22:31:25 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 22:33:11 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5a437a4b7b5131d913327804bd4cedb09f38548d
Cr-Commit-Position: refs/heads/master@{#398402}

Powered by Google App Engine
This is Rietveld 408576698