Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2047013005: Use different exit code when desired dep roll is a no-op (Closed)

Created:
4 years, 6 months ago by smut
Modified:
4 years, 6 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use different exit code when desired dep roll is a no-op BUG=609899 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/7036c4f0a63f61bfd7459cab352a0f5541590c27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M roll_dep.py View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
smut
Related to the widevine svn -> git migration. They used to use roll_dep_svn.py which didn't ...
4 years, 6 months ago (2016-06-08 22:56:49 UTC) #2
tandrii(chromium)
lgtm
4 years, 6 months ago (2016-06-09 10:57:50 UTC) #3
tandrii(chromium)
On 2016/06/09 10:57:50, tandrii(chromium) wrote: > lgtm note that depot_tools is on git now, you'd ...
4 years, 6 months ago (2016-06-09 10:58:25 UTC) #4
agable
LGTM. Shouldn't need to reupload, the CQ trusts the 'project' instead of the 'base_url' now, ...
4 years, 6 months ago (2016-06-09 16:40:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047013005/1
4 years, 6 months ago (2016-06-09 21:24:53 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 21:28:51 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/7036c4f0a63f61...

Powered by Google App Engine
This is Rietveld 408576698