Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2047013004: [heap] Fix Sweeper::IsSweepingCompleted (Closed)

Created:
4 years, 6 months ago by Michael Lippautz
Modified:
4 years, 6 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix Sweeper::IsSweepingCompleted R=ulan@chromium.org Committed: https://crrev.com/b4475fff4fe1c423a3c8c3b072e09becd6b2f8ed Cr-Commit-Position: refs/heads/master@{#36845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Michael Lippautz
PTAL This has actually been there for a long time (even before my refactoring) and ...
4 years, 6 months ago (2016-06-08 20:46:28 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047013004/1
4 years, 6 months ago (2016-06-08 20:46:53 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-08 21:12:37 UTC) #7
ulan
lgtm
4 years, 6 months ago (2016-06-09 08:58:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047013004/1
4 years, 6 months ago (2016-06-09 09:00:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 09:02:53 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b4475fff4fe1c423a3c8c3b072e09becd6b2f8ed Cr-Commit-Position: refs/heads/master@{#36845}
4 years, 6 months ago (2016-06-09 09:03:30 UTC) #14
Michael Lippautz
4 years, 6 months ago (2016-06-09 10:27:05 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2053623002/ by mlippautz@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10009.

Powered by Google App Engine
This is Rietveld 408576698