Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: styleguide/c++/c++11.html

Issue 2047013002: Add base::get to support rvalue-reference tuple (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: +test case Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/tuple_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: styleguide/c++/c++11.html
diff --git a/styleguide/c++/c++11.html b/styleguide/c++/c++11.html
index 6f1262b11a224cd0c1f3c1ee41fe3b527c2e9df8..1ffc465db94014aa862d945a7d08492f41b26c3f 100644
--- a/styleguide/c++/c++11.html
+++ b/styleguide/c++/c++11.html
@@ -454,7 +454,8 @@ template &lt;typename T&gt;<br/>void Function(T&& t) { ... }</code></td>
<td>All C++11 features in <code>&lt;tuple&gt;</code>, e.g. <code>std::tie</code> and <code>std::tuple</code>.</td>
<td>A fixed-size ordered collection of values of mixed types</td>
<td><a href="http://en.cppreference.com/w/cpp/header/tuple">&lt;tuple&gt;</a></td>
-<td>Prefer <code>std::tuple</code> over <a href="https://crbug.com/554987"><code>base::Tuple</code></a>.</td>
danakj 2016/06/22 22:37:49 I think you want to keep this line, we do prefer u
tzik 2016/06/23 04:37:29 We already replaced all usage of base::Tuple with
danakj 2016/06/23 20:41:05 Ooh, okay. Woops.
+<td>Use <code>base::get</code> instead of <code>std::get</code> in case the <code>std::tuple</code> may be a rvalue-reference.
+<code>std::get</code> in &lt;=libstdc++-4.6 misses an overload for rvalue-reference of a tuple, and <code>base::get</code> complements it. </td>
</tr>
<tr>
« no previous file with comments | « base/tuple_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698