Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2046963002: Version 5.1.281.61 (cherry-pick) (Closed)

Created:
4 years, 6 months ago by epertoso
Modified:
4 years, 6 months ago
Reviewers:
Jarin, Michael Hablich
CC:
Paweł Hajdan Jr., ulan, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.1
Target Ref:
refs/pending/branch-heads/5.1
Project:
v8
Visibility:
Public.

Description

Version 5.1.281.61 (cherry-pick) Merged 0d22e7e46a73bebb1e92768a8443a7b7b101051b [x64/ia32] Deal with the non-transitivity of InstructionSelector::CanCover() when folding loads into branches. BUG=chromium:611976 LOG=N R=hablich@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -11 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 3 chunks +15 lines, -5 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 3 chunks +15 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-branch-combine.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
epertoso
4 years, 6 months ago (2016-06-07 13:18:01 UTC) #1
epertoso
4 years, 6 months ago (2016-06-07 13:19:27 UTC) #4
epertoso
4 years, 6 months ago (2016-06-07 13:21:30 UTC) #6
Jarin
lgtm (rubber-stamp).
4 years, 6 months ago (2016-06-07 13:25:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046963002/1
4 years, 6 months ago (2016-06-07 13:47:16 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 13:47:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698