Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: tools/ic-explorer.html

Issue 2046943003: [ic] print map pointer value for --trace-ic (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/ic.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/ic-explorer.html
diff --git a/tools/ic-explorer.html b/tools/ic-explorer.html
index ad1737a6f77346c28ba81023f6d8b987e71c315c..8e5d4bd13ae994d4c32bbae79f9cc3aac8365626 100644
--- a/tools/ic-explorer.html
+++ b/tools/ic-explorer.html
@@ -51,6 +51,7 @@ code is governed by a BSD-style license that can be found in the LICENSE file.
if (parts[1] === "patching") return;
this.type = parts[0].substr(1);
this.category = "Other";
+ this.map = undefined;
if (this.type.indexOf("Store") !== -1) {
this.category = "Store";
} else if (this.type.indexOf("Load") !== -1) {
@@ -69,6 +70,13 @@ code is governed by a BSD-style license that can be found in the LICENSE file.
var offset = this.parsePositionAndFile(parts, 2);
if (offset == -1) return
this.state = parts[++offset];
+ this.map = parts[offset + 1];
+ if (this.map.startsWith("map=")) {
+ this.map = this.map.substring(4);
+ offset++;
+ } else {
+ this.map = undefined;
+ }
if (this.type !== "CompareIC") {
// if there is no address we have a smi key
var address = parts[++offset];
@@ -135,7 +143,6 @@ code is governed by a BSD-style license that can be found in the LICENSE file.
next = this.result.indexOf("\n", current);
if (next === -1) break;
i++;
-
line = this.result.substring(current, next);
current = next + 1;
entry = new Entry(i, line);
@@ -152,7 +159,7 @@ code is governed by a BSD-style license that can be found in the LICENSE file.
var properties = ['type', 'category', 'file', 'filePosition', 'state',
- 'key', 'isNative'
+ 'key', 'isNative', 'map'
]
class Group {
@@ -209,6 +216,14 @@ code is governed by a BSD-style license that can be found in the LICENSE file.
+ function escapeHtml(unsafe) {
+ return unsafe.toString()
+ .replace(/&/g, "&")
+ .replace(/</g, "&lt;")
+ .replace(/>/g, "&gt;")
+ .replace(/"/g, "&quot;")
+ .replace(/'/g, "&#039;");
+ }
function updateTable() {
var select = document.getElementById("group-key");
@@ -248,7 +263,7 @@ code is governed by a BSD-style license that can be found in the LICENSE file.
td(tr, '<span onclick="toggleDetails(this)">details</a>', 'details');
td(tr, entry.percentage + "%", 'percentage');
td(tr, entry.count, 'count');
- td(tr, entry.key, 'key');
+ td(tr, escapeHtml(entry.key), 'key');
fragment.appendChild(tr);
}
var omitted = entries.length - max;
@@ -282,7 +297,7 @@ code is governed by a BSD-style license that can be found in the LICENSE file.
var group = entry.groups[key];
var div = document.createElement("div")
div.className = 'drilldown-group-title'
- div.innerHTML = key + ' [top ' + max + ']';
+ div.innerHTML = key + ' [top ' + max + ' out of ' + group.length + ']';
var table = document.createElement("table");
display(group.slice(0, max), table, false)
div.appendChild(table);
« no previous file with comments | « src/ic/ic.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698