Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2046933003: WebAudio: record whether user gesture was available and provided. (Closed)

Created:
4 years, 6 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

WebAudio: record whether user gesture was available and provided. We are looking into a more consistent audio playback on mobile and want to see whether implementing Safari iOS behaviour in Chrome Android would break websites. BUG=616807 Review-Url: https://codereview.chromium.org/2031393003 Cr-Commit-Position: refs/heads/master@{#398061} (cherry picked from commit 9eeee90e6f8d52fce0b3645f933796abc13fe891) Committed: https://chromium.googlesource.com/chromium/src/+/cbcce37a04df2f0ca1b103827975d7b061e718bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp View 8 chunks +49 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioContext.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mlamouri (slow - plz ping)
4 years, 6 months ago (2016-06-07 19:44:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cbcce37a04df2f0ca1b103827975d7b061e718bb (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698