src/factory.cc - Issue 204693002: Handlify callers to GetElementNoException.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 204693002: Handlify callers to GetElementNoException. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fix Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 57574d1685234353cccfdc7ddfb03f084c206990..55529e57828c4499ff17e4225bffb5200d4e635b 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1132,8 +1132,7 @@ Handle<String> Factory::EmergencyNewError(const char* message,

space--;

if (space > 0) {

Handle<String> arg_str = Handle<String>::cast(

- Object::GetElement(isolate(), args, i));

- CHECK_NOT_EMPTY_HANDLE(isolate(), arg_str);

+ Object::GetElementNoExceptionThrown(isolate(), args, i));

SmartArrayPointer<char> arg = arg_str->ToCString();

Vector<char> v2(p, static_cast<int>(space));

OS::StrNCpy(v2, arg.get(), space);

« no previous file with comments | « src/execution.cc ('k') | src/liveedit.cc » ('j') | no next file with comments »