Reverting GN flip for Chrome Win (speculative)

Revert of Flip more Win bots to GN. (patchset #1 id:1 of https://codereview.chromium.org/2030823002/ )

Reason for revert:
Suspected to break Chrome Win builder. (Will revert this revert if it was a false alarm)

Error log:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/7879/steps/compile/logs/stdio

C:\b\build\scripts\slave\.recipe_deps\depot_tools\ninja.exe -w dupbuild=err -C C:\b\build\slave\google-chrome-rel-win\build\src\out\Release chrome chrome_official_builder_no_unittests -j200
ninja: Entering directory `C:\b\build\slave\google-chrome-rel-win\build\src\out\Release'
ninja: error: unknown target 'chrome_official_builder_no_unittests'

Original issue's description:
> Flip more Win bots to GN.
>
> This flips the remaining Win builders on the chromium, chromium.chrome,
> and chromium.perf waterfalls, as well as the matching trybots. The
> remaining GYP win builders are FYI bots, memory bots, and the official
> builders; the latter should be flipped ASAP after this lands to avoid
> any skew.
>
> R=brucedawson@chromium.org
> BUG=605319
>
> Committed: https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824
> Cr-Commit-Position: refs/heads/master@{#398033}

TBR=brucedawson@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605319
Committed: https://crrev.com/ffd608485f3df47c83c3216f717e6c1b1fc828ee
Cr-Commit-Position: refs/heads/master@{#398257}

[kinuko, 2016-06-07 08:20:11]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2016-06-07 08:20:12]

Created Revert of Flip more Win bots to GN.

[commit-bot: I haz the power, 2016-06-07 08:20:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046913002/1

[commit-bot: I haz the power, 2016-06-07 08:20:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 08:20:42]

Failed to apply patch for tools/mb/mb_config.pyl:
While running git apply --index -3 -p1;
  error: patch failed: tools/mb/mb_config.pyl:874
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: tools/mb/mb_config.pyl: patch does not apply

Patch:       tools/mb/mb_config.pyl
Index: tools/mb/mb_config.pyl
diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
index
8077b3167fb472f5f542c54ae0d19e4e23e207d8..86934cebc38ca4fda2e8ad24257b668ae896f646
100644
--- a/tools/mb/mb_config.pyl
+++ b/tools/mb/mb_config.pyl
@@ -15,7 +15,7 @@
       'Android': 'android_without_codecs_gn_release_bot_minimal_symbols',
       'Linux x64': 'noswarming_gn_release_bot',
       'Mac': 'noswarming_gyp_release_bot_mac_strip',
-      'Win': 'noswarming_gn_release_bot_minimal_symbols_x86',
+      'Win': 'noswarming_gyp_release_bot_minimal_symbols_x86',
       'Win x64': 'noswarming_gn_release_bot_minimal_symbols_x64',
     },
 
@@ -65,7 +65,7 @@
       'Google Chrome ChromeOS': 'gyp_official_goma_chromeos',
       'Google Chrome Linux x64': 'gn_official_goma',
       'Google Chrome Mac': 'gyp_official_goma',
-      'Google Chrome Win': 'gn_official_goma_minimal_symbols_x86',
+      'Google Chrome Win': 'gyp_official_goma_minimal_symbols_x86',
     },
 
     'chromium.chromiumos': {
@@ -501,13 +501,13 @@
       'Win 8 Perf (3)': 'none',
       'Win 8 Perf (4)': 'none',
       'Win 8 Perf (5)': 'none',
-      'Win Builder': 'gn_official_goma_minimal_symbols_x86',
+      'Win Builder': 'gyp_official_goma_minimal_symbols_x86',
       'Win Zenbook Perf (1)': 'none',
       'Win Zenbook Perf (2)': 'none',
       'Win Zenbook Perf (3)': 'none',
       'Win Zenbook Perf (4)': 'none',
       'Win Zenbook Perf (5)': 'none',
-      'Win x64 Builder': 'gn_official_goma_minimal_symbols_x64',
+      'Win x64 Builder': 'gyp_official_goma_minimal_symbols_x64',
     },
 
     'client.skia': {
@@ -846,8 +846,8 @@
       'win8_chromium_gn_dbg': 'swarming_gn_debug_trybot_x86',
       'win8_chromium_gn_upload': 'gn_release_bot_minimal_symbols_x86',
       'win8_chromium_ng': 'gn_release_trybot_x86',
-      'win_x64_archive': 'noswarming_gn_release_trybot_x64',
-      'win_archive': 'noswarming_gn_release_trybot_x86',
+      'win_x64_archive': 'noswarming_gyp_release_trybot_x64',
+      'win_archive': 'noswarming_gyp_release_trybot_x86',
       'win_chromium_compile_dbg_ng': 'swarming_gn_debug_trybot_x86',
       'win_chromium_compile_rel_ng':
         'swarming_gpu_tests_gn_release_trybot_x86',
@@ -874,7 +874,7 @@
         'swarming_gpu_tests_deqp_gles_gyp_release_trybot_x86',
       'win_pgo': 'gyp_official_winpgo',
       'win_upload_clang': 'gn_release_bot',
-      'win_chrome_official': 'gn_official_goma_minimal_symbols_x86',
+      'win_chrome_official': 'gyp_official_goma_minimal_symbols_x86',
     },
 
     'tryserver.v8': {
@@ -1133,14 +1133,6 @@
       'gn', 'official', 'goma', 'minimal_symbols', 'android', 'arm64',
     ],
 
-    'gn_official_goma_minimal_symbols_x64': [
-      'gn', 'official', 'goma', 'minimal_symbols', 'x64',
-    ],
-
-    'gn_official_goma_minimal_symbols_x86': [
-      'gn', 'official', 'goma', 'minimal_symbols', 'x86',
-    ],
-
     'gn_release_bot': [
       'gn', 'release_bot',
     ],
@@ -1426,16 +1418,20 @@
       'noswarming', 'gyp', 'release_bot', 'mac_strip',
     ],
 
+    'noswarming_gyp_release_bot_minimal_symbols_x86': [
+      'noswarming', 'gyp', 'release_bot', 'minimal_symbols', 'x86',
+    ],
+
     'noswarming_gyp_release_trybot': [
       'noswarming', 'gyp', 'release_trybot',
     ],
 
-    'noswarming_gn_release_trybot_x64': [
-      'noswarming', 'gn', 'release_trybot', 'x64',
-    ],
-
-    'noswarming_gn_release_trybot_x86': [
-      'noswarming', 'gn', 'release_trybot', 'x86',
+    'noswarming_gyp_release_trybot_x64': [
+      'noswarming', 'gyp', 'release_trybot', 'x64',
+    ],
+
+    'noswarming_gyp_release_trybot_x86': [
+      'noswarming', 'gyp', 'release_trybot', 'x86',
     ],
 
     'swarming_android_gn_debug_static_bot': [

[commit-bot: I haz the power, 2016-06-07 08:20:45]

The CQ bit was unchecked by commit-bot@chromium.org

[kinuko, 2016-06-07 09:15:44]

Um, ok apparently a lot more changes have been landed on top of it...

[kinuko, 2016-06-07 09:23:57]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2016-06-07 09:24:08]

The CQ bit was unchecked by kinuko@chromium.org

[kinuko, 2016-06-07 09:24:33]

Description was changed from

==========
Revert of Flip more Win bots to GN. (patchset #1 id:1 of
https://codereview.chromium.org/2030823002/ )

Reason for revert:
Suspected to break Chrome Win builder. (Will revert this revert if it was a
false alarm)

Error log:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

C:\b\build\scripts\slave\.recipe_deps\depot_tools\ninja.exe -w dupbuild=err -C
C:\b\build\slave\google-chrome-rel-win\build\src\out\Release chrome
chrome_official_builder_no_unittests -j200
ninja: Entering directory
`C:\b\build\slave\google-chrome-rel-win\build\src\out\Release'
ninja: error: unknown target 'chrome_official_builder_no_unittests'

Original issue's description:
> Flip more Win bots to GN.
> 
> This flips the remaining Win builders on the chromium, chromium.chrome,
> and chromium.perf waterfalls, as well as the matching trybots. The
> remaining GYP win builders are FYI bots, memory bots, and the official
> builders; the latter should be flipped ASAP after this lands to avoid
> any skew.
> 
> R=brucedawson@chromium.org
> BUG=605319
> 
> Committed: https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824
> Cr-Commit-Position: refs/heads/master@{#398033}

TBR=brucedawson@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605319
==========

to

==========
Revert of Flip more Win bots to GN. (patchset #1 id:1 of
https://codereview.chromium.org/2030823002/ )

Reason for revert:
Suspected to break Chrome Win builder. (Will revert this revert if it was a
false alarm)

Error log:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

C:\b\build\scripts\slave\.recipe_deps\depot_tools\ninja.exe -w dupbuild=err -C
C:\b\build\slave\google-chrome-rel-win\build\src\out\Release chrome
chrome_official_builder_no_unittests -j200
ninja: Entering directory
`C:\b\build\slave\google-chrome-rel-win\build\src\out\Release'
ninja: error: unknown target 'chrome_official_builder_no_unittests'

Original issue's description:
> Flip more Win bots to GN.
> 
> This flips the remaining Win builders on the chromium, chromium.chrome,
> and chromium.perf waterfalls, as well as the matching trybots. The
> remaining GYP win builders are FYI bots, memory bots, and the official
> builders; the latter should be flipped ASAP after this lands to avoid
> any skew.
> 
> R=brucedawson@chromium.org
> BUG=605319
> 
> Committed: https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824
> Cr-Commit-Position: refs/heads/master@{#398033}

TBR=brucedawson@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605319
==========

[kinuko, 2016-06-07 09:24:46]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2016-06-07 09:24:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046913002/40001

[commit-bot: I haz the power, 2016-06-07 09:25:43]

Description was changed from

==========
Revert of Flip more Win bots to GN. (patchset #1 id:1 of
https://codereview.chromium.org/2030823002/ )

Reason for revert:
Suspected to break Chrome Win builder. (Will revert this revert if it was a
false alarm)

Error log:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

C:\b\build\scripts\slave\.recipe_deps\depot_tools\ninja.exe -w dupbuild=err -C
C:\b\build\slave\google-chrome-rel-win\build\src\out\Release chrome
chrome_official_builder_no_unittests -j200
ninja: Entering directory
`C:\b\build\slave\google-chrome-rel-win\build\src\out\Release'
ninja: error: unknown target 'chrome_official_builder_no_unittests'

Original issue's description:
> Flip more Win bots to GN.
> 
> This flips the remaining Win builders on the chromium, chromium.chrome,
> and chromium.perf waterfalls, as well as the matching trybots. The
> remaining GYP win builders are FYI bots, memory bots, and the official
> builders; the latter should be flipped ASAP after this lands to avoid
> any skew.
> 
> R=brucedawson@chromium.org
> BUG=605319
> 
> Committed: https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824
> Cr-Commit-Position: refs/heads/master@{#398033}

TBR=brucedawson@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605319
==========

to

==========
Revert of Flip more Win bots to GN. (patchset #1 id:1 of
https://codereview.chromium.org/2030823002/ )

Reason for revert:
Suspected to break Chrome Win builder. (Will revert this revert if it was a
false alarm)

Error log:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

C:\b\build\scripts\slave\.recipe_deps\depot_tools\ninja.exe -w dupbuild=err -C
C:\b\build\slave\google-chrome-rel-win\build\src\out\Release chrome
chrome_official_builder_no_unittests -j200
ninja: Entering directory
`C:\b\build\slave\google-chrome-rel-win\build\src\out\Release'
ninja: error: unknown target 'chrome_official_builder_no_unittests'

Original issue's description:
> Flip more Win bots to GN.
> 
> This flips the remaining Win builders on the chromium, chromium.chrome,
> and chromium.perf waterfalls, as well as the matching trybots. The
> remaining GYP win builders are FYI bots, memory bots, and the official
> builders; the latter should be flipped ASAP after this lands to avoid
> any skew.
> 
> R=brucedawson@chromium.org
> BUG=605319
> 
> Committed: https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824
> Cr-Commit-Position: refs/heads/master@{#398033}

TBR=brucedawson@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605319
==========

[commit-bot: I haz the power, 2016-06-07 09:25:44]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-07 09:27:27]

Description was changed from

==========
Revert of Flip more Win bots to GN. (patchset #1 id:1 of
https://codereview.chromium.org/2030823002/ )

Reason for revert:
Suspected to break Chrome Win builder. (Will revert this revert if it was a
false alarm)

Error log:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

C:\b\build\scripts\slave\.recipe_deps\depot_tools\ninja.exe -w dupbuild=err -C
C:\b\build\slave\google-chrome-rel-win\build\src\out\Release chrome
chrome_official_builder_no_unittests -j200
ninja: Entering directory
`C:\b\build\slave\google-chrome-rel-win\build\src\out\Release'
ninja: error: unknown target 'chrome_official_builder_no_unittests'

Original issue's description:
> Flip more Win bots to GN.
> 
> This flips the remaining Win builders on the chromium, chromium.chrome,
> and chromium.perf waterfalls, as well as the matching trybots. The
> remaining GYP win builders are FYI bots, memory bots, and the official
> builders; the latter should be flipped ASAP after this lands to avoid
> any skew.
> 
> R=brucedawson@chromium.org
> BUG=605319
> 
> Committed: https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824
> Cr-Commit-Position: refs/heads/master@{#398033}

TBR=brucedawson@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605319
==========

to

==========
Revert of Flip more Win bots to GN. (patchset #1 id:1 of
https://codereview.chromium.org/2030823002/ )

Reason for revert:
Suspected to break Chrome Win builder. (Will revert this revert if it was a
false alarm)

Error log:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

C:\b\build\scripts\slave\.recipe_deps\depot_tools\ninja.exe -w dupbuild=err -C
C:\b\build\slave\google-chrome-rel-win\build\src\out\Release chrome
chrome_official_builder_no_unittests -j200
ninja: Entering directory
`C:\b\build\slave\google-chrome-rel-win\build\src\out\Release'
ninja: error: unknown target 'chrome_official_builder_no_unittests'

Original issue's description:
> Flip more Win bots to GN.
>
> This flips the remaining Win builders on the chromium, chromium.chrome,
> and chromium.perf waterfalls, as well as the matching trybots. The
> remaining GYP win builders are FYI bots, memory bots, and the official
> builders; the latter should be flipped ASAP after this lands to avoid
> any skew.
>
> R=brucedawson@chromium.org
> BUG=605319
>
> Committed: https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824
> Cr-Commit-Position: refs/heads/master@{#398033}

TBR=brucedawson@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605319

Committed: https://crrev.com/ffd608485f3df47c83c3216f717e6c1b1fc828ee
Cr-Commit-Position: refs/heads/master@{#398257}
==========

[commit-bot: I haz the power, 2016-06-07 09:27:28]

Patchset 2 (id:??) landed as
https://crrev.com/ffd608485f3df47c83c3216f717e6c1b1fc828ee
Cr-Commit-Position: refs/heads/master@{#398257}

[Dirk Pranke, 2016-06-07 16:31:34]

lgtm.