Enable filter-based -webkit-box-reflect.

Enable filter-based -webkit-box-reflect.

BUG=436475
Committed: https://crrev.com/2feb7b70fee5937747e7f8c637c9c90f56484d08
Cr-Commit-Position: refs/heads/master@{#398556}

[jbroman, 2016-06-07 20:08:51]

jbroman@chromium.org changed reviewers:
+ chrishtr@chromium.org, senorblanco@chromium.org

[jbroman, 2016-06-07 20:08:51]

jbroman@chromium.org changed required reviewers:
+ chrishtr@chromium.org, senorblanco@chromium.org

[jbroman, 2016-06-07 20:08:52]

See patch 1 to see the diffs; they're mostly imperceptible. There is one change
with how overlap works, but according to the test description this is a
progression.

Shipping this would allow us to remove some code supporting the legacy path, and
would make implementing reflection in SPv2 easier.

[Stephen White, 2016-06-07 20:42:51]

LGTM.

The changes to compositing/reflections/reflection-in-composited.html are
interesting. It looks
improved, but I'm wondering why. Is it an LCD text vs. non thing? Or a different
resampling mode in
the legacy vs. new codepaths?

[jbroman, 2016-06-07 20:46:05]

On 2016/06/07 at 20:42:51, senorblanco wrote:
> LGTM.
> 
> The changes to compositing/reflections/reflection-in-composited.html are
interesting. It looks
> improved, but I'm wondering why. Is it an LCD text vs. non thing? Or a
different resampling mode in
> the legacy vs. new codepaths?

I believe Skia is able to pixel-snap using the full CTM when filter-based
reflections aren't used, but when the filter is used (before the rotation),
pixel snapping happens in a coordinate system that's aligned with the border
box. The consequence is that the text appears a little blurrier, but also more
aligned, with this patch.

[chrishtr, 2016-06-07 22:08:43]

lgtm

[jbroman, 2016-06-08 15:04:48]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-06-08 15:05:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046883003/40001

[commit-bot: I haz the power, 2016-06-08 15:10:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-08 15:12:41]

Description was changed from

==========
Enable filter-based -webkit-box-reflect.

BUG=436475
==========

to

==========
Enable filter-based -webkit-box-reflect.

BUG=436475

Committed: https://crrev.com/2feb7b70fee5937747e7f8c637c9c90f56484d08
Cr-Commit-Position: refs/heads/master@{#398556}
==========

[commit-bot: I haz the power, 2016-06-08 15:12:42]

Patchset 3 (id:??) landed as
https://crrev.com/2feb7b70fee5937747e7f8c637c9c90f56484d08
Cr-Commit-Position: refs/heads/master@{#398556}