Remove traces of USE_NSS_CERTS from crypto/

Remove traces of USE_NSS_CERTS from crypto/

NSS is no longer an option as the cryptographic service
provider - all platforms have transitioned to using BoringSSL. Any remaining files in crypto/ that use NSS will always have USE_NSS_CERTS set.

This also fixes some unit tests that used the wrong ifdefs once
everything was converted to use BoringSSL.

BUG=604728
Committed: https://crrev.com/a3ad8d0bc490d62f9de55216f40f0135bdafd9dd
Cr-Commit-Position: refs/heads/master@{#398348}

[Ryan Sleevi, 2016-06-07 02:11:31]

rsleevi@chromium.org changed reviewers:
+ davidben@chromium.org, svaldez@chromium.org

[Ryan Sleevi, 2016-06-07 02:11:31]

Steven: Can you do primary review
David: Can you OWNERs stamp with Steven's happy & you're happy?

[svaldez, 2016-06-07 13:56:41]

lgtm

Might want to clarify the CL description. Took a couple reads. 

"As such, all remaining NSS code will only be used when NSS
certificates are being used, therefore USE_NSS_CERTS will always
be true in those files."

https://codereview.chromium.org/2046863002/diff/1/crypto/symmetric_key_unitte...
File crypto/symmetric_key_unittest.cc (left):

https://codereview.chromium.org/2046863002/diff/1/crypto/symmetric_key_unitte...
crypto/symmetric_key_unittest.cc:84: // The OS X crypto libraries have minimum
salt and iteration requirements
Seems to be separate from the NSS change? Add a note to the CL?

[Ryan Sleevi, 2016-06-07 14:57:55]

Description was changed from

==========
Remove traces of USE_NSS_CERTS from crypto/

NSS is no longer an option as the cryptographic service
provider - all platforms have transitioned to using BoringSSL. As
such, remove the traces of USE_NSS_CERTS segmentation from crypto/,
as if NSS is being used at all, it's for USE_NSS_CERTS.

This also fixes some unit tests that used the wrong ifdefs once
everything was converted to use BoringSSL.

BUG=604728
==========

to

==========
Remove traces of USE_NSS_CERTS from crypto/

NSS is no longer an option as the cryptographic service
provider - all platforms have transitioned to using BoringSSL. Any remaining
files in crypto/ that use NSS will always have USE_NSS_CERTS set.

This also fixes some unit tests that used the wrong ifdefs once
everything was converted to use BoringSSL.

BUG=604728
==========

[Ryan Sleevi, 2016-06-07 14:58:18]

https://codereview.chromium.org/2046863002/diff/1/crypto/symmetric_key_unitte...
File crypto/symmetric_key_unittest.cc (left):

https://codereview.chromium.org/2046863002/diff/1/crypto/symmetric_key_unitte...
crypto/symmetric_key_unittest.cc:84: // The OS X crypto libraries have minimum
salt and iteration requirements
On 2016/06/07 13:56:41, svaldez wrote:
> Seems to be separate from the NSS change? Add a note to the CL?

There already was one. The second paragraph.

[davidben, 2016-06-07 15:26:37]

lgtm

[Ryan Sleevi, 2016-06-07 15:33:19]

The CQ bit was checked by rsleevi@chromium.org

[commit-bot: I haz the power, 2016-06-07 15:33:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046863002/1

[commit-bot: I haz the power, 2016-06-07 17:30:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 17:30:08]

Try jobs failed on following builders:
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Ryan Sleevi, 2016-06-07 17:30:42]

The CQ bit was checked by rsleevi@chromium.org

[commit-bot: I haz the power, 2016-06-07 17:31:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046863002/1

[commit-bot: I haz the power, 2016-06-07 18:22:44]

Description was changed from

==========
Remove traces of USE_NSS_CERTS from crypto/

NSS is no longer an option as the cryptographic service
provider - all platforms have transitioned to using BoringSSL. Any remaining
files in crypto/ that use NSS will always have USE_NSS_CERTS set.

This also fixes some unit tests that used the wrong ifdefs once
everything was converted to use BoringSSL.

BUG=604728
==========

to

==========
Remove traces of USE_NSS_CERTS from crypto/

NSS is no longer an option as the cryptographic service
provider - all platforms have transitioned to using BoringSSL. Any remaining
files in crypto/ that use NSS will always have USE_NSS_CERTS set.

This also fixes some unit tests that used the wrong ifdefs once
everything was converted to use BoringSSL.

BUG=604728
==========

[commit-bot: I haz the power, 2016-06-07 18:22:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-07 18:25:01]

Description was changed from

==========
Remove traces of USE_NSS_CERTS from crypto/

NSS is no longer an option as the cryptographic service
provider - all platforms have transitioned to using BoringSSL. Any remaining
files in crypto/ that use NSS will always have USE_NSS_CERTS set.

This also fixes some unit tests that used the wrong ifdefs once
everything was converted to use BoringSSL.

BUG=604728
==========

to

==========
Remove traces of USE_NSS_CERTS from crypto/

NSS is no longer an option as the cryptographic service
provider - all platforms have transitioned to using BoringSSL. Any remaining
files in crypto/ that use NSS will always have USE_NSS_CERTS set.

This also fixes some unit tests that used the wrong ifdefs once
everything was converted to use BoringSSL.

BUG=604728

Committed: https://crrev.com/a3ad8d0bc490d62f9de55216f40f0135bdafd9dd
Cr-Commit-Position: refs/heads/master@{#398348}
==========

[commit-bot: I haz the power, 2016-06-07 18:25:02]

Patchset 1 (id:??) landed as
https://crrev.com/a3ad8d0bc490d62f9de55216f40f0135bdafd9dd
Cr-Commit-Position: refs/heads/master@{#398348}