mash: Migrate shelf menus to wm common types

mash: Migrate shelf menus to wm common types

This is a dependency of ShelfView.

* Inject WmShelf into Shelf and ShelfView to start breaking up dependencies on
Shelf.
* Change ShellDelegate::CreateContextMenu() to use WmShelf.
* Allow WmShelf to manipulate auto-hide state.
* Move shelf menu UMA stats to common.

I'll move the files into //ash/common in a separate CL so that the changes to
shelf_alignment_menu.cc don't look like a rewrite.

BUG=615155
TEST=existing ash_unittests and chrome unit_tests

Committed: https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c
Cr-Commit-Position: refs/heads/master@{#398735}

[James Cook, 2016-06-08 16:26:17]

Description was changed from

==========
WIP: Migrate shelf menus to wm common types and move to //ash/common

git squash commit.

6f8b1ef330af370aab8ceb533b8351f89a59aab2
Move ShelfMenuModel and ShelfAlignmentMenu to //ash/common, but //ash/sysui
needs to pass in a Shelf*

9c85b58b82917539a42336640f3fed227cb4df94
revert most of the ShellDelegate changes

3a2f5b9f9092f0523f02b2e82ed3a01520d736db
pass WmShelf into Shelf

BUG=
==========

to

==========
WIP: mash: Migrate shelf menus to wm common types

git squash commit.

6f8b1ef330af370aab8ceb533b8351f89a59aab2
Move ShelfMenuModel and ShelfAlignmentMenu to //ash/common, but //ash/sysui
needs to pass in a Shelf*

9c85b58b82917539a42336640f3fed227cb4df94
revert most of the ShellDelegate changes

3a2f5b9f9092f0523f02b2e82ed3a01520d736db
pass WmShelf into Shelf

BUG=
==========

[James Cook, 2016-06-08 17:25:46]

Description was changed from

==========
WIP: mash: Migrate shelf menus to wm common types

git squash commit.

6f8b1ef330af370aab8ceb533b8351f89a59aab2
Move ShelfMenuModel and ShelfAlignmentMenu to //ash/common, but //ash/sysui
needs to pass in a Shelf*

9c85b58b82917539a42336640f3fed227cb4df94
revert most of the ShellDelegate changes

3a2f5b9f9092f0523f02b2e82ed3a01520d736db
pass WmShelf into Shelf

BUG=
==========

to

==========
mash: Migrate shelf menus to wm common types

This is a dependency of ShelfView.

* Inject WmShelf into Shelf and ShelfView to start breaking up dependencies on
Shelf.
* Change ShellDelegate::CreateContextMenu() to use WmShelf.
* Allow WmShelf to manipulate auto-hide state.
* Move shelf menu UMA stats to common.

I'll move the files into //ash/common in a separate CL so that the changes to
shelf_alignment_menu.cc don't look like a rewrite.

BUG=615155
TEST=existing ash_unittests and chrome unit_tests
==========

[James Cook, 2016-06-08 17:28:33]

Description was changed from

==========
mash: Migrate shelf menus to wm common types

This is a dependency of ShelfView.

* Inject WmShelf into Shelf and ShelfView to start breaking up dependencies on
Shelf.
* Change ShellDelegate::CreateContextMenu() to use WmShelf.
* Allow WmShelf to manipulate auto-hide state.
* Move shelf menu UMA stats to common.

I'll move the files into //ash/common in a separate CL so that the changes to
shelf_alignment_menu.cc don't look like a rewrite.

BUG=615155
TEST=existing ash_unittests and chrome unit_tests
==========

to

==========
mash: Migrate shelf menus to wm common types

This is a dependency of ShelfView.

* Inject WmShelf into Shelf and ShelfView to start breaking up dependencies on
Shelf.
* Change ShellDelegate::CreateContextMenu() to use WmShelf.
* Allow WmShelf to manipulate auto-hide state.
* Move shelf menu UMA stats to common.

I'll move the files into //ash/common in a separate CL so that the changes to
shelf_alignment_menu.cc don't look like a rewrite.

BUG=615155
TEST=existing ash_unittests and chrome unit_tests
==========

[James Cook, 2016-06-08 17:33:15]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-06-08 17:33:16]

sky, please take a look.

[sky, 2016-06-08 20:09:35]

LGTM

[James Cook, 2016-06-08 21:42:02]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-06-08 21:42:02]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2046843005/#ps60001
(title: "rebase, fix tests")

[commit-bot: I haz the power, 2016-06-08 21:42:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046843005/60001

[commit-bot: I haz the power, 2016-06-08 21:59:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 21:59:07]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-06-08 22:42:34]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-06-08 22:42:34]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2046843005/#ps80001
(title: "ash_shell_with_content")

[commit-bot: I haz the power, 2016-06-08 22:42:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046843005/80001

[commit-bot: I haz the power, 2016-06-08 23:39:12]

Description was changed from

==========
mash: Migrate shelf menus to wm common types

This is a dependency of ShelfView.

* Inject WmShelf into Shelf and ShelfView to start breaking up dependencies on
Shelf.
* Change ShellDelegate::CreateContextMenu() to use WmShelf.
* Allow WmShelf to manipulate auto-hide state.
* Move shelf menu UMA stats to common.

I'll move the files into //ash/common in a separate CL so that the changes to
shelf_alignment_menu.cc don't look like a rewrite.

BUG=615155
TEST=existing ash_unittests and chrome unit_tests
==========

to

==========
mash: Migrate shelf menus to wm common types

This is a dependency of ShelfView.

* Inject WmShelf into Shelf and ShelfView to start breaking up dependencies on
Shelf.
* Change ShellDelegate::CreateContextMenu() to use WmShelf.
* Allow WmShelf to manipulate auto-hide state.
* Move shelf menu UMA stats to common.

I'll move the files into //ash/common in a separate CL so that the changes to
shelf_alignment_menu.cc don't look like a rewrite.

BUG=615155
TEST=existing ash_unittests and chrome unit_tests
==========

[commit-bot: I haz the power, 2016-06-08 23:39:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-08 23:40:55]

Description was changed from

==========
mash: Migrate shelf menus to wm common types

This is a dependency of ShelfView.

* Inject WmShelf into Shelf and ShelfView to start breaking up dependencies on
Shelf.
* Change ShellDelegate::CreateContextMenu() to use WmShelf.
* Allow WmShelf to manipulate auto-hide state.
* Move shelf menu UMA stats to common.

I'll move the files into //ash/common in a separate CL so that the changes to
shelf_alignment_menu.cc don't look like a rewrite.

BUG=615155
TEST=existing ash_unittests and chrome unit_tests
==========

to

==========
mash: Migrate shelf menus to wm common types

This is a dependency of ShelfView.

* Inject WmShelf into Shelf and ShelfView to start breaking up dependencies on
Shelf.
* Change ShellDelegate::CreateContextMenu() to use WmShelf.
* Allow WmShelf to manipulate auto-hide state.
* Move shelf menu UMA stats to common.

I'll move the files into //ash/common in a separate CL so that the changes to
shelf_alignment_menu.cc don't look like a rewrite.

BUG=615155
TEST=existing ash_unittests and chrome unit_tests

Committed: https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c
Cr-Commit-Position: refs/heads/master@{#398735}
==========

[commit-bot: I haz the power, 2016-06-08 23:40:56]

Patchset 5 (id:??) landed as
https://crrev.com/da53c1490a2ec1a040cefb23492cbc68d873162c
Cr-Commit-Position: refs/heads/master@{#398735}