Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2046833003:
Change Android GPU tests to use Chromium instead of content_shell. (Closed)
|
Created:
4 years, 6 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 6 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, telemetry-reviews_chromium.org, piman+watch_chromium.org, ghost stip (do not use), Geoff Lang, Corentin Wallez Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange Android GPU tests to use Chromium instead of content_shell.
As an added benefit, this should allow some of the multi-tab GPU tests
to be enabled on Android.
BUG=616392
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/eefa898fe35430bd07ec1e4d08ca643f740b0c52
Cr-Commit-Position: refs/heads/master@{#398696}
Patch Set 1 #Patch Set 2 : Rebased. #
Messages
Total messages: 31 (13 generated)
Description was changed from ========== Change Android GPU tests to use Chromium instead of content_shell. As an added benefit, this should allow some of the multi-tab GPU tests to be enabled on Android. BUG=616392 ========== to ========== Change Android GPU tests to use Chromium instead of content_shell. As an added benefit, this should allow some of the multi-tab GPU tests to be enabled on Android. BUG=616392 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + cblume@chromium.org, ynovikov@chromium.org
ynovikov or cblume: please review. If you could test this locally it would be great. stip: FYI.
On 2016/06/07 05:19:45, Ken Russell wrote: > ynovikov or cblume: please review. If you could test this locally it would be > great. > > stip: FYI. LGTM but I will test locally tomorrow first thing
On 2016/06/07 05:42:24, cblume wrote: > On 2016/06/07 05:19:45, Ken Russell wrote: > > ynovikov or cblume: please review. If you could test this locally it would be > > great. > > > > stip: FYI. > > LGTM but I will test locally tomorrow first thing I only just got to this. I tested the pixel tests on a N6 and things seemed to run mostly as expected. It gave me 3 test failures: Canvas2DRedBox, CSS3DBlueBox, and 2DCanvasWebGL. These three tests aren't in my pixel expectations. I seem to recall seeing these 3 tests failing before, however. I also ran the webgl conformance tests. 5 tests failed (792 passed): conformance/textures/video/* These do not seem to be in the expectations file. Is it possible that android-chromium would cause other tests to fail? Either way, I think it might still be worth landing this and then we can update the expectations if there are surprises.
On 2016/06/07 20:15:41, cblume wrote: > On 2016/06/07 05:42:24, cblume wrote: > > On 2016/06/07 05:19:45, Ken Russell wrote: > > > ynovikov or cblume: please review. If you could test this locally it would > be > > > great. > > > > > > stip: FYI. > > > > LGTM but I will test locally tomorrow first thing > > I only just got to this. > > I tested the pixel tests on a N6 and things seemed to run mostly as expected. > It gave me 3 test failures: Canvas2DRedBox, CSS3DBlueBox, and 2DCanvasWebGL. > These three tests aren't in my pixel expectations. I seem to recall seeing these > 3 tests failing before, however. > > I also ran the webgl conformance tests. > 5 tests failed (792 passed): conformance/textures/video/* > These do not seem to be in the expectations file. > > Is it possible that android-chromium would cause other tests to fail? Either > way, I think it might still be worth landing this and then we can update the > expectations if there are surprises. Thanks for testing. Maybe chromium takes the hardware-accelerated video decoding path where content_shell doesn't, or similar. Agree, let's land this and add suppressions for new failures. CQ'ing.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046833003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
kbr@chromium.org changed reviewers: + aiolos@chromium.org
Argh - forgot to add aiolos@ as reviewer.
kbr@chromium.org changed reviewers: + nednguyen@google.com - aiolos@chromium.org
nednguyen: OWNERS review please.
lgtm
OK, let's try this.
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, cblume@chromium.org Link to the patchset: https://codereview.chromium.org/2046833003/#ps20001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046833003/20001
stip@chromium.org changed reviewers: + stip@chromium.org
lgtm
Note (esp. to cblume and ynovikov): if anyone sees breakage of the Android bots on the chromium.gpu.fyi waterfall after this lands, please either revert, or TBR= test expectation updates to me. Thanks.
aiolos@chromium.org changed reviewers: + aiolos@chromium.org
Sorry, I've been at the diversity summit and forgot to update my reviewer name. lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_optional_gpu_tests_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046833003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Change Android GPU tests to use Chromium instead of content_shell. As an added benefit, this should allow some of the multi-tab GPU tests to be enabled on Android. BUG=616392 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Change Android GPU tests to use Chromium instead of content_shell. As an added benefit, this should allow some of the multi-tab GPU tests to be enabled on Android. BUG=616392 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/eefa898fe35430bd07ec1e4d08ca643f740b0c52 Cr-Commit-Position: refs/heads/master@{#398696} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/eefa898fe35430bd07ec1e4d08ca643f740b0c52 Cr-Commit-Position: refs/heads/master@{#398696} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
