Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 204683002: Make the shmem-specific functions in file_util.h POSIX-only. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Make the shmem-specific functions in file_util.h POSIX-only. They're only used on POSIX. (This is an initial move/removal; more to come.) R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -51 lines) Patch
M base/file_util.h View 3 chunks +15 lines, -15 lines 0 comments Download
M base/file_util_posix.cc View 3 chunks +27 lines, -27 lines 0 comments Download
M base/file_util_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/file_util_win.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-19 16:13:05 UTC) #1
brettw
lgtm
6 years, 9 months ago (2014-03-19 22:05:23 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-20 04:41:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/204683002/1
6 years, 9 months ago (2014-03-20 04:41:46 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 07:06:49 UTC) #5
Message was sent while issue was closed.
Change committed as 258242

Powered by Google App Engine
This is Rietveld 408576698