Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2046813002: [css] Don't let table parts be layout boundaries (Closed)

Created:
4 years, 6 months ago by dgrogan
Modified:
4 years, 6 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css] Don't let table parts be layout boundaries This fixes another crash when table parts are set as containment roots. <table> elements still don't honor layout containment when calculating their dimensions, though. BUG=616643 Committed: https://crrev.com/f73b8a9314d1730f80600d0c89d55fac4ab20624 Cr-Commit-Position: refs/heads/master@{#398207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
A + third_party/WebKit/LayoutTests/fast/table/containment-crash.html View 2 chunks +7 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/table/containment-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dgrogan
Emil, could you review this?
4 years, 6 months ago (2016-06-06 22:14:09 UTC) #4
eae
OK LGTM
4 years, 6 months ago (2016-06-06 22:17:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046813002/1
4 years, 6 months ago (2016-06-06 22:22:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 02:45:00 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 02:47:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f73b8a9314d1730f80600d0c89d55fac4ab20624
Cr-Commit-Position: refs/heads/master@{#398207}

Powered by Google App Engine
This is Rietveld 408576698