Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 20468002: Allow equality operation on mixed double/smi arguments. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_mips.cc
===================================================================
--- runtime/vm/intermediate_language_mips.cc (revision 25478)
+++ runtime/vm/intermediate_language_mips.cc (working copy)
@@ -272,7 +272,7 @@
LocationSummary* EqualityCompareInstr::MakeLocationSummary() const {
const intptr_t kNumInputs = 2;
- if (receiver_class_id() == kMintCid) {
+ if (operation_cid() == kMintCid) {
const intptr_t kNumTemps = 1;
LocationSummary* locs =
new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
@@ -282,7 +282,7 @@
locs->set_out(Location::RequiresRegister());
return locs;
}
- if (receiver_class_id() == kDoubleCid) {
+ if (operation_cid() == kDoubleCid) {
const intptr_t kNumTemps = 0;
LocationSummary* locs =
new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
@@ -291,7 +291,7 @@
locs->set_out(Location::RequiresRegister());
return locs;
}
- if (receiver_class_id() == kSmiCid) {
+ if (operation_cid() == kSmiCid) {
const intptr_t kNumTemps = 0;
LocationSummary* locs =
new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
@@ -794,15 +794,15 @@
ASSERT((kind() == Token::kNE) || (kind() == Token::kEQ));
BranchInstr* kNoBranch = NULL;
__ Comment("EqualityCompareInstr");
- if (receiver_class_id() == kSmiCid) {
+ if (operation_cid() == kSmiCid) {
EmitSmiComparisonOp(compiler, *locs(), kind(), kNoBranch);
return;
}
- if (receiver_class_id() == kMintCid) {
+ if (operation_cid() == kMintCid) {
EmitUnboxedMintEqualityOp(compiler, *locs(), kind(), kNoBranch);
return;
}
- if (receiver_class_id() == kDoubleCid) {
+ if (operation_cid() == kDoubleCid) {
EmitDoubleComparisonOp(compiler, *locs(), kind(), kNoBranch);
return;
}
@@ -838,16 +838,16 @@
__ TraceSimMsg("EqualityCompareInstr");
__ Comment("EqualityCompareInstr:BranchCode");
ASSERT((kind() == Token::kNE) || (kind() == Token::kEQ));
- if (receiver_class_id() == kSmiCid) {
+ if (operation_cid() == kSmiCid) {
// Deoptimizes if both arguments not Smi.
EmitSmiComparisonOp(compiler, *locs(), kind(), branch);
return;
}
- if (receiver_class_id() == kMintCid) {
+ if (operation_cid() == kMintCid) {
EmitUnboxedMintEqualityOp(compiler, *locs(), kind(), branch);
return;
}
- if (receiver_class_id() == kDoubleCid) {
+ if (operation_cid() == kDoubleCid) {
EmitDoubleComparisonOp(compiler, *locs(), kind(), branch);
return;
}
@@ -886,7 +886,7 @@
LocationSummary* RelationalOpInstr::MakeLocationSummary() const {
const intptr_t kNumInputs = 2;
const intptr_t kNumTemps = 0;
- if (operands_class_id() == kMintCid) {
+ if (operation_cid() == kMintCid) {
const intptr_t kNumTemps = 2;
LocationSummary* locs =
new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
@@ -897,14 +897,14 @@
locs->set_out(Location::RequiresRegister());
return locs;
}
- if (operands_class_id() == kDoubleCid) {
+ if (operation_cid() == kDoubleCid) {
LocationSummary* summary =
new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
summary->set_in(0, Location::RequiresFpuRegister());
summary->set_in(1, Location::RequiresFpuRegister());
summary->set_out(Location::RequiresRegister());
return summary;
- } else if (operands_class_id() == kSmiCid) {
+ } else if (operation_cid() == kSmiCid) {
LocationSummary* summary =
new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
summary->set_in(0, Location::RegisterOrConstant(left()));
@@ -928,15 +928,15 @@
void RelationalOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ TraceSimMsg("RelationalOpInstr");
- if (operands_class_id() == kSmiCid) {
+ if (operation_cid() == kSmiCid) {
EmitSmiComparisonOp(compiler, *locs(), kind(), NULL);
return;
}
- if (operands_class_id() == kMintCid) {
+ if (operation_cid() == kMintCid) {
EmitUnboxedMintComparisonOp(compiler, *locs(), kind(), NULL);
return;
}
- if (operands_class_id() == kDoubleCid) {
+ if (operation_cid() == kDoubleCid) {
EmitDoubleComparisonOp(compiler, *locs(), kind(), NULL);
return;
}
@@ -1005,15 +1005,15 @@
void RelationalOpInstr::EmitBranchCode(FlowGraphCompiler* compiler,
BranchInstr* branch) {
__ TraceSimMsg("RelationalOpInstr");
- if (operands_class_id() == kSmiCid) {
+ if (operation_cid() == kSmiCid) {
EmitSmiComparisonOp(compiler, *locs(), kind(), branch);
return;
}
- if (operands_class_id() == kMintCid) {
+ if (operation_cid() == kMintCid) {
EmitUnboxedMintComparisonOp(compiler, *locs(), kind(), branch);
return;
}
- if (operands_class_id() == kDoubleCid) {
+ if (operation_cid() == kDoubleCid) {
EmitDoubleComparisonOp(compiler, *locs(), kind(), branch);
return;
}

Powered by Google App Engine
This is Rietveld 408576698