Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2046783002: Allow deletion of profiles in the old user manager when all profiles are locked (Closed)

Created:
4 years, 6 months ago by Moe
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow deletion of profiles in the old user manager when all profiles are locked BUG=617016 Signed-off-by: mahmadi <mahmadi@chromium.org>; Committed: https://crrev.com/6c60f35ad6b0991b7cd5766ba7def8c36ba1c72b Cr-Commit-Position: refs/heads/master@{#398405}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Moe
Hi Roger, Please review this CL.
4 years, 6 months ago (2016-06-06 21:44:24 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
4 years, 6 months ago (2016-06-07 14:23:10 UTC) #3
Moe
On 2016/06/07 14:23:10, Roger Tawa wrote: > lgtm Thank you.
4 years, 6 months ago (2016-06-07 14:25:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046783002/1
4 years, 6 months ago (2016-06-07 14:25:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/17220) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-07 14:27:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046783002/20001
4 years, 6 months ago (2016-06-07 15:42:18 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/215294)
4 years, 6 months ago (2016-06-07 16:34:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046783002/20001
4 years, 6 months ago (2016-06-07 21:43:44 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 22:41:25 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 22:43:48 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c60f35ad6b0991b7cd5766ba7def8c36ba1c72b
Cr-Commit-Position: refs/heads/master@{#398405}

Powered by Google App Engine
This is Rietveld 408576698