third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp - Issue 2046733003: Replicate WebInsecureRequestPolicy instead of a bool for strict mixed content checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 2046733003: Replicate WebInsecureRequestPolicy instead of a bool for strict mixed content checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@securitycontext

Patch Set: alexmos@ Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

index e9c08e2b9a8ebcc4dcb1174dfbee4b75c3e1f3fc..9e4b630214cf67fe66321f99d5fbdf262205ffff 100644

--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

@@ -658,12 +658,10 @@ void WebRemoteFrameImpl::resetReplicatedContentSecurityPolicy() const

frame()->securityContext()->resetReplicatedContentSecurityPolicy();

}

-void WebRemoteFrameImpl::setReplicatedShouldEnforceStrictMixedContentChecking(bool shouldEnforce) const

+void WebRemoteFrameImpl::setReplicatedInsecureRequestPolicy(WebInsecureRequestPolicy policy) const

{

DCHECK(frame());

- WebInsecureRequestPolicy oldPolicy = frame()->securityContext()->getInsecureRequestPolicy();

- WebInsecureRequestPolicy newPolicy = shouldEnforce ? oldPolicy | kBlockAllMixedContent : oldPolicy & ~kBlockAllMixedContent;

- frame()->securityContext()->setInsecureRequestPolicy(newPolicy);

+ frame()->securityContext()->setInsecureRequestPolicy(policy);

}

void WebRemoteFrameImpl::setReplicatedPotentiallyTrustworthyUniqueOrigin(bool isUniqueOriginPotentiallyTrustworthy) const

« no previous file with comments | « third_party/WebKit/Source/web/WebRemoteFrameImpl.h ('k') | third_party/WebKit/public/web/WebFrame.h » ('j') | no next file with comments »