Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: Source/web/EditorClientImpl.cpp

Issue 204673007: Move didChangeSelection to WebFrameClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: update Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/EditorClientImpl.h ('k') | public/web/WebFrameClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007 Apple, Inc. All rights reserved. 2 * Copyright (C) 2006, 2007 Apple, Inc. All rights reserved.
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 14 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
17 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 17 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
18 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 18 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
19 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 19 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
20 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 20 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */ 25 */
26 26
27 #include "config.h" 27 #include "config.h"
28 #include "EditorClientImpl.h" 28 #include "EditorClientImpl.h"
29 29
30 #include "WebFrameClient.h"
30 #include "WebFrameImpl.h" 31 #include "WebFrameImpl.h"
31 #include "WebPermissionClient.h" 32 #include "WebPermissionClient.h"
32 #include "WebViewClient.h" 33 #include "WebViewClient.h"
33 #include "WebViewImpl.h" 34 #include "WebViewImpl.h"
34 #include "core/editing/SelectionType.h" 35 #include "core/editing/SelectionType.h"
35 36
36 using namespace WebCore; 37 using namespace WebCore;
37 38
38 namespace blink { 39 namespace blink {
39 40
40 EditorClientImpl::EditorClientImpl(WebViewImpl* webview) 41 EditorClientImpl::EditorClientImpl(WebViewImpl* webview)
41 : m_webView(webview) 42 : m_webView(webview)
42 { 43 {
43 } 44 }
44 45
45 EditorClientImpl::~EditorClientImpl() 46 EditorClientImpl::~EditorClientImpl()
46 { 47 {
47 } 48 }
48 49
49 void EditorClientImpl::respondToChangedSelection(WebCore::SelectionType selectio nType) 50 void EditorClientImpl::respondToChangedSelection(LocalFrame* frame, WebCore::Sel ectionType selectionType)
50 { 51 {
51 if (m_webView->client()) 52 WebFrameImpl* webFrame = WebFrameImpl::fromFrame(frame);
52 m_webView->client()->didChangeSelection(selectionType != WebCore::RangeS election); 53 if (webFrame->client())
54 webFrame->client()->didChangeSelection(selectionType != WebCore::RangeSe lection);
53 } 55 }
54 56
55 void EditorClientImpl::respondToChangedContents() 57 void EditorClientImpl::respondToChangedContents()
56 { 58 {
57 if (m_webView->client()) 59 if (m_webView->client())
58 m_webView->client()->didChangeContents(); 60 m_webView->client()->didChangeContents();
59 } 61 }
60 62
61 bool EditorClientImpl::canCopyCut(LocalFrame* frame, bool defaultValue) const 63 bool EditorClientImpl::canCopyCut(LocalFrame* frame, bool defaultValue) const
62 { 64 {
(...skipping 16 matching lines...) Expand all
79 if (m_webView->client()) 81 if (m_webView->client())
80 m_webView->client()->didExecuteCommand(WebString(commandName)); 82 m_webView->client()->didExecuteCommand(WebString(commandName));
81 } 83 }
82 84
83 bool EditorClientImpl::handleKeyboardEvent() 85 bool EditorClientImpl::handleKeyboardEvent()
84 { 86 {
85 return m_webView->client() && m_webView->client()->handleCurrentKeyboardEven t(); 87 return m_webView->client() && m_webView->client()->handleCurrentKeyboardEven t();
86 } 88 }
87 89
88 } // namesace blink 90 } // namesace blink
OLDNEW
« no previous file with comments | « Source/web/EditorClientImpl.h ('k') | public/web/WebFrameClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698