Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 204673005: Turn off WebRTC feature should not break the build on Linux (Closed)

Created:
6 years, 9 months ago by yi
Modified:
6 years, 9 months ago
Reviewers:
perkj_chrome, yzshen1
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Turn off WebRTC feature should not break the build on Linux BUG=354082 R= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258421

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/pepper/resource_converter.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
perkj_chrome
yzshen - is this something you know anything about or know who?
6 years, 9 months ago (2014-03-20 11:48:43 UTC) #1
yzshen1
lgtm
6 years, 9 months ago (2014-03-20 15:58:42 UTC) #2
yi
The CQ bit was checked by yi.shen@samsung.com
6 years, 9 months ago (2014-03-20 18:19:36 UTC) #3
yi
On 2014/03/20 15:58:42, yzshen1 wrote: > lgtm Thanks for review!
6 years, 9 months ago (2014-03-20 18:20:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yi.shen@samsung.com/204673005/1
6 years, 9 months ago (2014-03-20 18:24:33 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 21:47:12 UTC) #6
Message was sent while issue was closed. 
Change committed as 258421

Powered by Google App Engine
This is Rietveld 408576698