Issue 204673004: Use monotonic time for SVGImage's serviceScriptedAnimations()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204673004: Use monotonic time for SVGImage's serviceScriptedAnimations() (Closed)

Created:
6 years, 9 months ago by fs

Modified:
6 years, 9 months ago

Reviewers:
pdr., f(malita), Stephen Chennney, rwlbuis

CC:
blink-reviews, krit, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Use monotonic time for SVGImage's serviceScriptedAnimations() Breakage from r168748 which used the wrong time-source. BUG=231576 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169645

Created: 6 years, 9 months ago

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -0 lines)
A	LayoutTests/svg/as-image/animated-svg-wrong-timesource.html	View	1 chunk	+15 lines, -0 lines	0 comments
A +	LayoutTests/svg/as-image/animated-svg-wrong-timesource-expected.html	View	0 chunks	+-1 lines, --1 lines	0 comments
M	Source/core/svg/graphics/SVGImageChromeClient.cpp	View	1 chunk	+1 line, -1 line	0 comments

Total messages: 6 (0 generated)

Apparently test coverage is missing for this case... I'll try to add a TC for ...

6 years, 9 months ago (2014-03-19 17:46:12 UTC) #1

pdr.

On 2014/03/19 17:46:12, fs wrote: > Apparently test coverage is missing for this case... I'll ...

6 years, 9 months ago (2014-03-19 17:48:22 UTC) #2

On 2014/03/19 17:48:22, pdr wrote: > On 2014/03/19 17:46:12, fs wrote: > > Apparently test ...

6 years, 9 months ago (2014-03-20 10:30:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/204673004/20001

6 years, 9 months ago (2014-03-20 10:31:11 UTC) #5

Message was sent while issue was closed.

Change committed as 169645