Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 204673004: Use monotonic time for SVGImage's serviceScriptedAnimations() (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
CC:
blink-reviews, krit, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis
Visibility:
Public.

Description

Use monotonic time for SVGImage's serviceScriptedAnimations() Breakage from r168748 which used the wrong time-source. BUG=231576 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169645

Patch Set 1 #

Patch Set 2 : Added TC. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
A LayoutTests/svg/as-image/animated-svg-wrong-timesource.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
A + LayoutTests/svg/as-image/animated-svg-wrong-timesource-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
fs
Apparently test coverage is missing for this case... I'll try to add a TC for ...
6 years, 9 months ago (2014-03-19 17:46:12 UTC) #1
pdr.
On 2014/03/19 17:46:12, fs wrote: > Apparently test coverage is missing for this case... I'll ...
6 years, 9 months ago (2014-03-19 17:48:22 UTC) #2
fs
On 2014/03/19 17:48:22, pdr wrote: > On 2014/03/19 17:46:12, fs wrote: > > Apparently test ...
6 years, 9 months ago (2014-03-20 10:30:14 UTC) #3
fs
The CQ bit was checked by fs@opera.com
6 years, 9 months ago (2014-03-20 10:31:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/204673004/20001
6 years, 9 months ago (2014-03-20 10:31:11 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 11:57:32 UTC) #6
Message was sent while issue was closed.
Change committed as 169645

Powered by Google App Engine
This is Rietveld 408576698