Oilpan: Disable the GC_PLUGIN_IGNORE annotation when compiling with asan.

Oilpan: Disable the GC_PLUGIN_IGNORE annotation when compiling with asan.

For some reason having this annotation leads to linker errors on the
oilpan asan build.

obj/third_party/WebKit/Source/modules/libmodules.a(obj/third_party/WebKit/Source/modules/webdatabase/modules.DatabaseSync.o):../../third_party/WebKit/Source/modules/webdatabase/DatabaseSync.cpp:function __unnamed_1: error: undefined reference to '.str'

obj/third_party/WebKit/Source/modules/libmodules.a(obj/third_party/WebKit/Source/modules/webdatabase/modules.DatabaseSync.o):../../third_party/WebKit/Source/modules/webdatabase/DatabaseSync.cpp:function __unnamed_1: error: undefined reference to '.str1'

Kostya, do you have any ideas why this might break the asan build?

R=kcc@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169564

[Mads Ager (chromium), 2014-03-19 16:08:22]

+ oilpan-reviews

[Vyacheslav Egorov (Google), 2014-03-19 16:08:44]

lgtm

[Mads Ager (chromium), 2014-03-19 16:09:23]

The CQ bit was checked by ager@chromium.org

[commit-bot: I haz the power, 2014-03-19 16:09:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ager@chromium.org/204673002/1

[wibling-chromium, 2014-03-19 16:14:40]

lgtm

[haraken, 2014-03-19 16:23:40]

LGTM

[commit-bot: I haz the power, 2014-03-19 17:22:07]

Change committed as 169564

[kcc1, 2014-03-20 07:49:09]

>> Kostya, do you have any ideas why this might break the asan build?

No idea :( 
Do you by any chance have a small repro?
Glider?

[Alexander Potapenko, 2014-03-20 08:13:02]

The CL disables both GC_PLUGIN_IGNORE and STACK_ALLOCATED under ASan. Is only
GC_PLUGIN_IGNORE sufficient to fix the problem?

[Alexander Potapenko, 2014-03-20 08:20:46]

On 2014/03/20 08:13:02, Alexander Potapenko wrote:
> The CL disables both GC_PLUGIN_IGNORE and STACK_ALLOCATED under ASan. Is only
> GC_PLUGIN_IGNORE sufficient to fix the problem?

Opened https://code.google.com/p/address-sanitizer/issues/detail?id=279 with a
repro.

[Mads Ager (chromium), 2014-03-20 08:36:30]

On 2014/03/20 08:20:46, Alexander Potapenko wrote:
> On 2014/03/20 08:13:02, Alexander Potapenko wrote:
> > The CL disables both GC_PLUGIN_IGNORE and STACK_ALLOCATED under ASan. Is
only
> > GC_PLUGIN_IGNORE sufficient to fix the problem?
> 
> Opened https://code.google.com/p/address-sanitizer/issues/detail?id=279 with a
> repro.

Excellent. Thanks!

Yeah, it is enough to just disable GC_PLUGIN_IGNORE. All our other clang builds
will still get the compile-time verification that STACK_ALLOCATED gives us so it
is fine to just disable it only on the ASAN build until we understand how to fix
it.

[Alexander Potapenko, 2014-03-20 14:28:02]

I've fixed the bug today, so it'll be fine to enable the annotation back
after the Clang roll following the upcoming one.
On Mar 20, 2014 12:36 PM, <ager@chromium.org> wrote:

> On 2014/03/20 08:20:46, Alexander Potapenko wrote:
>
>> On 2014/03/20 08:13:02, Alexander Potapenko wrote:
>> > The CL disables both GC_PLUGIN_IGNORE and STACK_ALLOCATED under ASan. Is
>>
> only
>
>> > GC_PLUGIN_IGNORE sufficient to fix the problem?
>>
>
>  Opened https://code.google.com/p/address-sanitizer/issues/detail?id=279with
a
>> repro.
>>
>
> Excellent. Thanks!
>
> Yeah, it is enough to just disable GC_PLUGIN_IGNORE. All our other clang
> builds
> will still get the compile-time verification that STACK_ALLOCATED gives us
> so it
> is fine to just disable it only on the ASAN build until we understand how
> to fix
> it.
>
> https://codereview.chromium.org/204673002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Mads Ager (chromium), 2014-03-20 14:53:04]

Awesome. Thanks Alexander!


On Thu, Mar 20, 2014 at 3:28 PM, Alexander Potapenko
<glider@chromium.org>wrote:

> I've fixed the bug today, so it'll be fine to enable the annotation back
> after the Clang roll following the upcoming one.
> On Mar 20, 2014 12:36 PM, <ager@chromium.org> wrote:
>
>> On 2014/03/20 08:20:46, Alexander Potapenko wrote:
>>
>>> On 2014/03/20 08:13:02, Alexander Potapenko wrote:
>>> > The CL disables both GC_PLUGIN_IGNORE and STACK_ALLOCATED under ASan.
>>> Is
>>>
>> only
>>
>>> > GC_PLUGIN_IGNORE sufficient to fix the problem?
>>>
>>
>>  Opened https://code.google.com/p/address-sanitizer/issues/detail?id=279with
a
>>> repro.
>>>
>>
>> Excellent. Thanks!
>>
>> Yeah, it is enough to just disable GC_PLUGIN_IGNORE. All our other clang
>> builds
>> will still get the compile-time verification that STACK_ALLOCATED gives
>> us so it
>> is fine to just disable it only on the ASAN build until we understand how
>> to fix
>> it.
>>
>> https://codereview.chromium.org/204673002/
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.