Removing unused SetBrowserContext

Removing unused SetBrowserContext

This method is no longer used, and should be removed.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/49aa1b1aa1009b551934f3fece61955bfb32445d
Cr-Commit-Position: refs/heads/master@{#398216}

[RyanSturm, 2016-06-06 19:41:59]

Description was changed from

==========
Removing unused SetBrowserContext

This method is no longer used, and should be removed.

BUG=
==========

to

==========
Removing unused SetBrowserContext

This method is no longer used, and should be removed.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[RyanSturm, 2016-06-06 19:51:56]

ryansturm@chromium.org changed reviewers:
+ nasko@chromium.org

[RyanSturm, 2016-06-06 19:51:57]

Nasko: PTAL
I also const'ed the pointer part of browser_context_ since this won't change
after construction.

[nasko, 2016-06-06 21:46:52]

LGTM with a nit. Thanks for cleaning up code!

https://codereview.chromium.org/2046713002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_controller_impl.h (right):

https://codereview.chromium.org/2046713002/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl.h:364: BrowserContext*
const browser_context_;
Let's keep this CL to only removing the API. If you want to push to make the
context const, let's do this separately.

[RyanSturm, 2016-06-06 22:22:15]

On 2016/06/06 21:46:52, nasko (slow) wrote:
> LGTM with a nit. Thanks for cleaning up code!
> 
>
https://codereview.chromium.org/2046713002/diff/1/content/browser/frame_host/...
> File content/browser/frame_host/navigation_controller_impl.h (right):
> 
>
https://codereview.chromium.org/2046713002/diff/1/content/browser/frame_host/...
> content/browser/frame_host/navigation_controller_impl.h:364: BrowserContext*
> const browser_context_;
> Let's keep this CL to only removing the API. If you want to push to make the
> context const, let's do this separately.

I'll leave the pointer as non-const for now.

[RyanSturm, 2016-06-06 22:39:14]

Patchset #2 (id:20001) has been deleted

[RyanSturm, 2016-06-07 02:04:00]

The CQ bit was checked by ryansturm@chromium.org

[RyanSturm, 2016-06-07 02:04:01]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2046713002/#ps40001
(title: "removing const from BrowserContext* const")

[commit-bot: I haz the power, 2016-06-07 02:04:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046713002/40001

[commit-bot: I haz the power, 2016-06-07 03:37:14]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-07 03:41:41]

Description was changed from

==========
Removing unused SetBrowserContext

This method is no longer used, and should be removed.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Removing unused SetBrowserContext

This method is no longer used, and should be removed.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/49aa1b1aa1009b551934f3fece61955bfb32445d
Cr-Commit-Position: refs/heads/master@{#398216}
==========

[commit-bot: I haz the power, 2016-06-07 03:41:42]

Patchset 2 (id:??) landed as
https://crrev.com/49aa1b1aa1009b551934f3fece61955bfb32445d
Cr-Commit-Position: refs/heads/master@{#398216}