Inline two argument shuffle operations on IA32 and X64.

runtime/vm/disassembler_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/disassembler.h"
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 #include "platform/utils.h"
 #include "vm/allocation.h"
@@ skipping 208 matching lines @@
 }
 
 
 static InstructionTable instruction_table;
 
 
 // Mnemonics for instructions 0xF0 byte.
 // Returns NULL if the instruction is not handled here.
 static const char* F0Mnem(uint8_t f0byte) {
   switch (f0byte) {
+    case 0x12: return "movhlps";
+    case 0x14: return "unpcklps";
+    case 0x15: return "unpckhps";
+    case 0x16: return "movlhps";
     case 0xA2: return "cpuid";
     case 0x31: return "rdtsc";
     case 0xBE: return "movsx_b";
     case 0xBF: return "movsx_w";
     case 0xB6: return "movzx_b";
     case 0xB7: return "movzx_w";
     case 0xAF: return "imul";
     case 0xA5: return "shld";
     case 0xAD: return "shrd";
     case 0xAB: return "bts";
@@ skipping 12 matching lines @@
     case 0x5E: return "divps";
     case 0x5F: return "maxps";
     case 0x28: return "movaps";
     case 0x10: return "movups";
     case 0x11: return "movups";
     default: return NULL;
   }
 }
 
 
+static bool IsTwoXmmRegInstruction(uint8_t f0byte) {
+  return f0byte == 0x28 || f0byte == 0x11 || f0byte == 0x12 ||
+         f0byte == 0x14 || f0byte == 0x15 || f0byte == 0x16 ||
+         f0byte == 0x51 || f0byte == 0x52 || f0byte == 0x53 ||
+         f0byte == 0x54 || f0byte == 0x56 || f0byte == 0x58 ||
+         f0byte == 0x59 || f0byte == 0x5C || f0byte == 0x5D ||
+         f0byte == 0x5E || f0byte == 0x5F;
+}
+
+
 // The implementation of x86 decoding based on the above tables.
 class X86Decoder : public ValueObject {
  public:
   X86Decoder(char* buffer, intptr_t buffer_size)
       : buffer_(buffer),
         buffer_size_(buffer_size),
         buffer_pos_(0) {
     buffer_[buffer_pos_] = '\0';
   }
 
@@ skipping 1084 matching lines @@
             Print(" ");
             data += PrintRightOperand(data);
             if (f0byte == 0xAB) {
               Print(",");
               PrintCPURegister(regop);
             } else {
               Print(",");
               PrintCPURegister(regop);
               Print(",cl");
             }
-          } else if (f0byte == 0x28) {
-            // movaps
-            Print(f0mnem);
-            int mod, regop, rm;
-            GetModRm(*data, &mod, &regop, &rm);
-            Print(" ");
-            PrintXmmRegister(regop);
-            Print(",");
-            data += PrintRightXmmOperand(data);
-          } else if (f0byte == 0x11) {
-            Print("movups ");
-            int mod, regop, rm;
-            GetModRm(*data, &mod, &regop, &rm);
-            data += PrintRightXmmOperand(data);
-            Print(",");
-            PrintXmmRegister(regop);
           } else if (f0byte == 0x10) {
             int mod, regop, rm;
             GetModRm(*data, &mod, &regop, &rm);
             Print("movups ");
             PrintXmmRegister(regop);
             Print(",");
             data += PrintRightOperand(data);
-          } else if (f0byte == 0x51 || f0byte == 0x52 || f0byte == 0x53 ||
-                     f0byte == 0x54 || f0byte == 0x56 || f0byte == 0x58 ||
-                     f0byte == 0x59 || f0byte == 0x5C || f0byte == 0x5D ||
-                     f0byte == 0x5E || f0byte == 0x5F) {
+          } else if (IsTwoXmmRegInstruction(f0byte)) {
             int mod, regop, rm;
             GetModRm(*data, &mod, &regop, &rm);
             Print(f0mnem);
             Print(" ");
             PrintXmmRegister(regop);
             Print(",");
             data += PrintRightXmmOperand(data);
           } else if (f0byte == 0x50) {
             Print("movmskpd ");
             int mod, regop, rm;
@@ skipping 189 matching lines @@
               Print("roundsd ");
               PrintXmmRegister(regop);
               Print(", ");
               PrintXmmRegister(rm);
               Print(", ");
               PrintInt(data[1] & 3);
               data += 2;
             } else {
               UNIMPLEMENTED();
             }
+          } else if (*data == 0x14) {
+            int mod, regop, rm;
+            GetModRm(*(data+1), &mod, &regop, &rm);
+            Print("unpcklpd ");
+            PrintXmmRegister(regop);
+            Print(",");
+            PrintXmmRegister(rm);
+            data += 2;
+          } else if (*data == 0x15) {
+            int mod, regop, rm;
+            GetModRm(*(data+1), &mod, &regop, &rm);
+            Print("unpckhpd ");
+            PrintXmmRegister(regop);
+            Print(",");
+            PrintXmmRegister(rm);
+            data += 2;
           } else {
             UNIMPLEMENTED();
           }
         } else if (*data == 0x90) {
           data++;
           Print("nop");
         } else {
           UNIMPLEMENTED();
         }
         break;
@@ skipping 196 matching lines @@
                                   pc);
     pc += instruction_length;
   }
 
   return;
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32