Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 2046683003: [gn] Add extra library files in stand-alone mode. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Add extra library files in stand-alone mode. BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org NOTRY=true Committed: https://crrev.com/68e77d2fad1af90461043ddd7e958c1fe62458d7 Cr-Commit-Position: refs/heads/master@{#36777}

Patch Set 1 #

Total comments: 1

Patch Set 2 : grammar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build_overrides/v8.gni View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Michael Achenbach
TBR https://codereview.chromium.org/2046683003/diff/1/build_overrides/v8.gni File build_overrides/v8.gni (right): https://codereview.chromium.org/2046683003/diff/1/build_overrides/v8.gni#newcode25 build_overrides/v8.gni:25: # Add a simple extras solely for the ...
4 years, 6 months ago (2016-06-07 08:53:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046683003/1
4 years, 6 months ago (2016-06-07 08:53:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046683003/20001
4 years, 6 months ago (2016-06-07 08:54:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 08:56:17 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/68e77d2fad1af90461043ddd7e958c1fe62458d7 Cr-Commit-Position: refs/heads/master@{#36777}
4 years, 6 months ago (2016-06-07 08:57:54 UTC) #12
vogelheim
4 years, 6 months ago (2016-06-07 13:15:09 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698