Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 2046663002: [Remoting Android] Releases |secret_fetcher_| in DisconnectFromHost() (Closed)

Created:
4 years, 6 months ago by Yuwei
Modified:
4 years, 6 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Releases |secret_fetcher_| in DisconnectFromHost() In some situations the same JniClient will be used for multiple connections where ConnectToHost()->DisconnectFromHost()->ConnectToHost() will be called. In ConnectToHost() we DCHECK !secret_fetcher_ but don't release it in DisconnectFromHost(), which fails the DCHECK. This CL solves this problem by resetting |secret_fetcher_| in DisconnectFromHost(). However, we still need to investigate why JniClient is being used for multiple connections. BUG=617471 Committed: https://crrev.com/909aa6b2ac08abe5d75cdb5050c979c29ef451e3 Cr-Commit-Position: refs/heads/master@{#398085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M remoting/client/jni/jni_client.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yuwei
PTAL
4 years, 6 months ago (2016-06-06 18:06:41 UTC) #2
Lambros
lgtm
4 years, 6 months ago (2016-06-06 18:13:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046663002/1
4 years, 6 months ago (2016-06-06 18:14:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 19:18:13 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 19:20:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/909aa6b2ac08abe5d75cdb5050c979c29ef451e3
Cr-Commit-Position: refs/heads/master@{#398085}

Powered by Google App Engine
This is Rietveld 408576698