Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2046633006: MruWindowTrackerTest for mash (Closed)

Created:
4 years, 6 months ago by sky
Modified:
4 years, 6 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MruWindowTrackerTest for mash BUG=617789, 618058 TEST=test only change R=jamescook@chromium.org Committed: https://crrev.com/34ff3fb8a90313138cdc1732410414c7b51e862e Cr-Commit-Position: refs/heads/master@{#398686}

Patch Set 1 #

Patch Set 2 : relative #

Patch Set 3 : merge #

Patch Set 4 : merge #

Patch Set 5 : merge #

Patch Set 6 : CreateTestWindow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -52 lines) Patch
M ash/mus/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/wm/mru_window_tracker_unittest.cc View 1 2 3 4 5 2 chunks +52 lines, -52 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
sky
4 years, 6 months ago (2016-06-07 22:38:01 UTC) #1
James Cook
lgtm
4 years, 6 months ago (2016-06-08 00:23:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046633006/80001
4 years, 6 months ago (2016-06-08 17:37:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/160193)
4 years, 6 months ago (2016-06-08 18:33:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046633006/100001
4 years, 6 months ago (2016-06-08 20:24:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/150065)
4 years, 6 months ago (2016-06-08 20:43:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046633006/100001
4 years, 6 months ago (2016-06-08 21:01:14 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-08 21:37:30 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 21:39:42 UTC) #17
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/34ff3fb8a90313138cdc1732410414c7b51e862e
Cr-Commit-Position: refs/heads/master@{#398686}

Powered by Google App Engine
This is Rietveld 408576698