Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2046633005: setup_toolchain.py: Fix the path to win_sdk/bin/SetEnv*.json (Closed)

Created:
4 years, 6 months ago by hans
Modified:
4 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

setup_toolchain.py: Fix the path to win_sdk/bin/SetEnv*.json The 'bin' part should be lowercase. This matters on case-sensitive filesystems, such as those commonly used on Linux. BUG=495204 Committed: https://crrev.com/7a5ad5a66ab0283e2c8093b2e3f04ad1a22e337e Cr-Commit-Position: refs/heads/master@{#398340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/toolchain/win/setup_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
hans
Please take a look.
4 years, 6 months ago (2016-06-07 15:49:55 UTC) #2
Nico
lgtm
4 years, 6 months ago (2016-06-07 16:29:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046633005/1
4 years, 6 months ago (2016-06-07 16:32:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 18:09:28 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 18:11:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a5ad5a66ab0283e2c8093b2e3f04ad1a22e337e
Cr-Commit-Position: refs/heads/master@{#398340}

Powered by Google App Engine
This is Rietveld 408576698