Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2046633003: [Courgette] Fix BSDiff License Headers; Remove Entries in checklicense.py (Closed)

Created:
4 years, 6 months ago by huangs
Modified:
4 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, huangs+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Courgette] Fix BSDiff License Headers; Remove Entries in checklicense.py Previously bsdiff_create.cc and qsufsort.h do not start with proper copyright notices, and were added as exceptions in checklicense.py. This CL cleans up license headers for BSDiff-related files, which allows the exceptions to be removed. BUG=98095 Committed: https://crrev.com/d02d3057fcfa441fa9b07dc0ba1855e04ff52b63 Cr-Commit-Position: refs/heads/master@{#399908}

Patch Set 1 #

Patch Set 2 : Put back FreeBSD license; remove file description snippet. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -133 lines) Patch
M courgette/third_party/bsdiff/README.chromium View 1 chunk +10 lines, -10 lines 0 comments Download
M courgette/third_party/bsdiff/bsdiff.h View 1 1 chunk +40 lines, -35 lines 0 comments Download
M courgette/third_party/bsdiff/bsdiff_apply.cc View 1 1 chunk +32 lines, -31 lines 0 comments Download
M courgette/third_party/bsdiff/bsdiff_create.cc View 1 1 chunk +50 lines, -27 lines 0 comments Download
M courgette/third_party/bsdiff/qsufsort.h View 1 1 chunk +46 lines, -24 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
huangs
PTAL. Thanks!
4 years, 6 months ago (2016-06-06 17:42:46 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046633003/1
4 years, 6 months ago (2016-06-06 17:43:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 19:04:08 UTC) #7
huangs
Ping Paweł, PTAL.
4 years, 6 months ago (2016-06-07 16:38:08 UTC) #8
huangs
Per off-line discussion, need to go through review for licenses. Doing eng-review: go/courgette-use-libdivsufsort .
4 years, 6 months ago (2016-06-13 15:36:25 UTC) #9
Paweł Hajdan Jr.
LGTM For reference, this was approved in https://goto.google.com/zkirn .
4 years, 6 months ago (2016-06-15 08:14:18 UTC) #10
huangs
Thanks! Committing.
4 years, 6 months ago (2016-06-15 14:48:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046633003/20001
4 years, 6 months ago (2016-06-15 14:49:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 16:00:21 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 16:00:31 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 16:02:30 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d02d3057fcfa441fa9b07dc0ba1855e04ff52b63
Cr-Commit-Position: refs/heads/master@{#399908}

Powered by Google App Engine
This is Rietveld 408576698