Chromium Code Reviews Chromium Code Reviews
Issue
2046613002:
Do not crash on null stream in writing to bidirectional streams (Closed)
DescriptionDo not crash on null stream in writing to bidirectional streams
When SendData/SendvData is called, it might be that OnClose
has been invoked without an error, in which case
BidirectionalStream::Delegate::OnFailed would not have been
invoked. This is theoretically possible, but I am not
aware if such case would exist.
This CL removes the assumption that SendData/SendvData
is only called when stream is alive. If stream is
destroyed, propagate that as an ERR_UNEXPECTED to caller,
instead of crashing with a segfault.
BUG=606394
TBR=mef@chromium.org
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2032733002
Cr-Commit-Position: refs/heads/master@{#398031}
(cherry picked from commit 707f895efd414219d609533e82be1ffc60fd9788)
Patch Set 1 #
Messages
Total messages: 6 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
