third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp - Issue 2046593003: Fix Document::firstPartyForCookies() for OOPIFs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp

Issue 2046593003: Fix Document::firstPartyForCookies() for OOPIFs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use the top frame in the remote case and add a test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp

diff --git a/third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp b/third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp

index 3195403548d66aa427d93ee5f89d15782563039a..be4f185c8067f6ee6bf9b37f2f3cec2eba4d28ac 100644

--- a/third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp

+++ b/third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp

@@ -402,6 +402,12 @@ void SchemeRegistry::registerURLSchemeAsFirstPartyWhenTopLevel(const String& sch

firstPartyWhenTopLevelSchemes().add(scheme);

}

+void SchemeRegistry::removeURLSchemeAsFirstPartyWhenTopLevel(const String& scheme)

+ MutexLocker locker(mutex());

+ firstPartyWhenTopLevelSchemes().remove(scheme);

bool SchemeRegistry::shouldTreatURLSchemeAsFirstPartyWhenTopLevel(const String& scheme)

{

if (scheme.isEmpty())