Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: base/BUILD.gn

Issue 2046583002: Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR grt #10 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/base.gyp » ('j') | base/file_version_info_win.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
(...skipping 1732 matching lines...) Expand 10 before | Expand all | Expand 10 after
1743 "cpu_unittest.cc", 1743 "cpu_unittest.cc",
1744 "debug/crash_logging_unittest.cc", 1744 "debug/crash_logging_unittest.cc",
1745 "debug/debugger_unittest.cc", 1745 "debug/debugger_unittest.cc",
1746 "debug/leak_tracker_unittest.cc", 1746 "debug/leak_tracker_unittest.cc",
1747 "debug/proc_maps_linux_unittest.cc", 1747 "debug/proc_maps_linux_unittest.cc",
1748 "debug/stack_trace_unittest.cc", 1748 "debug/stack_trace_unittest.cc",
1749 "debug/task_annotator_unittest.cc", 1749 "debug/task_annotator_unittest.cc",
1750 "deferred_sequenced_task_runner_unittest.cc", 1750 "deferred_sequenced_task_runner_unittest.cc",
1751 "environment_unittest.cc", 1751 "environment_unittest.cc",
1752 "feature_list_unittest.cc", 1752 "feature_list_unittest.cc",
1753 "file_version_info_unittest.cc", 1753 "file_version_info_win_unittest.cc",
1754 "files/dir_reader_posix_unittest.cc", 1754 "files/dir_reader_posix_unittest.cc",
1755 "files/file_locking_unittest.cc", 1755 "files/file_locking_unittest.cc",
1756 "files/file_path_unittest.cc", 1756 "files/file_path_unittest.cc",
1757 "files/file_path_watcher_unittest.cc", 1757 "files/file_path_watcher_unittest.cc",
1758 "files/file_proxy_unittest.cc", 1758 "files/file_proxy_unittest.cc",
1759 "files/file_unittest.cc", 1759 "files/file_unittest.cc",
1760 "files/file_util_proxy_unittest.cc", 1760 "files/file_util_proxy_unittest.cc",
1761 "files/file_util_unittest.cc", 1761 "files/file_util_unittest.cc",
1762 "files/important_file_writer_unittest.cc", 1762 "files/important_file_writer_unittest.cc",
1763 "files/memory_mapped_file_unittest.cc", 1763 "files/memory_mapped_file_unittest.cc",
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
2049 } 2049 }
2050 2050
2051 if (is_mac) { 2051 if (is_mac) {
2052 libs = [ 2052 libs = [
2053 "CoreFoundation.framework", 2053 "CoreFoundation.framework",
2054 "Foundation.framework", 2054 "Foundation.framework",
2055 ] 2055 ]
2056 } 2056 }
2057 2057
2058 if (is_linux) { 2058 if (is_linux) {
2059 sources -= [ "file_version_info_unittest.cc" ]
2060
2061 if (is_desktop_linux) { 2059 if (is_desktop_linux) {
2062 sources += [ "nix/xdg_util_unittest.cc" ] 2060 sources += [ "nix/xdg_util_unittest.cc" ]
2063 } 2061 }
2064 2062
2065 deps += [ "//base/test:malloc_wrapper" ] 2063 deps += [ "//base/test:malloc_wrapper" ]
2066 2064
2067 if (use_glib) { 2065 if (use_glib) {
2068 configs += [ "//build/config/linux:glib" ] 2066 configs += [ "//build/config/linux:glib" ]
2069 } 2067 }
2070 2068
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
2417 2415
2418 # GYP: //base.gyp:base_java_unittest_support 2416 # GYP: //base.gyp:base_java_unittest_support
2419 android_library("base_java_unittest_support") { 2417 android_library("base_java_unittest_support") {
2420 deps = [ 2418 deps = [
2421 ":base_java", 2419 ":base_java",
2422 ] 2420 ]
2423 java_files = 2421 java_files =
2424 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ] 2422 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
2425 } 2423 }
2426 } 2424 }
OLDNEW
« no previous file with comments | « no previous file | base/base.gyp » ('j') | base/file_version_info_win.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698