Shard content_browser to avoid MSVS 2 GB limitation.

Shard content_browser to avoid MSVS 2 GB limitation.

A change to enable WPO for the x64 Win official builds caused
content_browserto expand beyond 2 GB which caused these errors:

  obj\content\content_browser.lib : fatal error LNK1107: invalid or
  corrupt file: cannot read at 0xEAE7739

msvs_shard is a way of breaking up a library to avoid this limitation.

This issue doesn't affect the GN builds (because they use a sourceset
concept instead of these huge static libraries).

TBR=creis@chromium.org
BUG=616946
Committed: https://crrev.com/c9dd766b9c61d5a4186ce8d3c1bbf830ad27b2f2
Cr-Commit-Position: refs/heads/master@{#398112}

[Sébastien Marchand, 2016-06-06 17:11:07]

Description was changed from

==========
Shard content_browser to avoid MSVS 2 GB limitation.

A change to enable WPO for the x64 Win official builds caused
content_browserto expand beyond 2 GB which caused these errors:

  obj\content\content_browser.lib : fatal error LNK1107: invalid or
  corrupt file: cannot read at 0xEAE7739

msvs_shard is a way of breaking up a library to avoid this limitation.

BUG=616946
==========

to

==========
Shard content_browser to avoid MSVS 2 GB limitation.

A change to enable WPO for the x64 Win official builds caused
content_browserto expand beyond 2 GB which caused these errors:

  obj\content\content_browser.lib : fatal error LNK1107: invalid or
  corrupt file: cannot read at 0xEAE7739

msvs_shard is a way of breaking up a library to avoid this limitation.

This issue doesn't affect the GN builds (because they use a sourceset
concept instead of these huge static libraries).

BUG=616946
==========

[Sébastien Marchand, 2016-06-06 17:11:27]

sebmarchand@chromium.org changed reviewers:
+ scottmg@chromium.org

[Sébastien Marchand, 2016-06-06 17:11:27]

PTAL.

[scottmg, 2016-06-06 17:29:10]

lgtm

[Sébastien Marchand, 2016-06-06 17:32:06]

sebmarchand@chromium.org changed reviewers:
+ creis@chromium.org, nasko@chromium.org

[Sébastien Marchand, 2016-06-06 17:32:29]

+nasko@ and creis@ for owner approval (first one to reply win!)

[Sébastien Marchand, 2016-06-06 19:32:13]

Description was changed from

==========
Shard content_browser to avoid MSVS 2 GB limitation.

A change to enable WPO for the x64 Win official builds caused
content_browserto expand beyond 2 GB which caused these errors:

  obj\content\content_browser.lib : fatal error LNK1107: invalid or
  corrupt file: cannot read at 0xEAE7739

msvs_shard is a way of breaking up a library to avoid this limitation.

This issue doesn't affect the GN builds (because they use a sourceset
concept instead of these huge static libraries).

BUG=616946
==========

to

==========
Shard content_browser to avoid MSVS 2 GB limitation.

A change to enable WPO for the x64 Win official builds caused
content_browserto expand beyond 2 GB which caused these errors:

  obj\content\content_browser.lib : fatal error LNK1107: invalid or
  corrupt file: cannot read at 0xEAE7739

msvs_shard is a way of breaking up a library to avoid this limitation.

This issue doesn't affect the GN builds (because they use a sourceset
concept instead of these huge static libraries).

TBR=creis@chromium.org
BUG=616946
==========

[Sébastien Marchand, 2016-06-06 19:32:37]

TBR'ing as it's blocking the perf team and it's a minor change.

[Sébastien Marchand, 2016-06-06 19:32:40]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-06-06 19:33:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046573003/1

[Charlie Reis, 2016-06-06 20:30:06]

Rubber stamp LGTM.

[commit-bot: I haz the power, 2016-06-06 20:34:29]

Description was changed from

==========
Shard content_browser to avoid MSVS 2 GB limitation.

A change to enable WPO for the x64 Win official builds caused
content_browserto expand beyond 2 GB which caused these errors:

  obj\content\content_browser.lib : fatal error LNK1107: invalid or
  corrupt file: cannot read at 0xEAE7739

msvs_shard is a way of breaking up a library to avoid this limitation.

This issue doesn't affect the GN builds (because they use a sourceset
concept instead of these huge static libraries).

TBR=creis@chromium.org
BUG=616946
==========

to

==========
Shard content_browser to avoid MSVS 2 GB limitation.

A change to enable WPO for the x64 Win official builds caused
content_browserto expand beyond 2 GB which caused these errors:

  obj\content\content_browser.lib : fatal error LNK1107: invalid or
  corrupt file: cannot read at 0xEAE7739

msvs_shard is a way of breaking up a library to avoid this limitation.

This issue doesn't affect the GN builds (because they use a sourceset
concept instead of these huge static libraries).

TBR=creis@chromium.org
BUG=616946
==========

[commit-bot: I haz the power, 2016-06-06 20:34:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-06 20:36:10]

Description was changed from

==========
Shard content_browser to avoid MSVS 2 GB limitation.

A change to enable WPO for the x64 Win official builds caused
content_browserto expand beyond 2 GB which caused these errors:

  obj\content\content_browser.lib : fatal error LNK1107: invalid or
  corrupt file: cannot read at 0xEAE7739

msvs_shard is a way of breaking up a library to avoid this limitation.

This issue doesn't affect the GN builds (because they use a sourceset
concept instead of these huge static libraries).

TBR=creis@chromium.org
BUG=616946
==========

to

==========
Shard content_browser to avoid MSVS 2 GB limitation.

A change to enable WPO for the x64 Win official builds caused
content_browserto expand beyond 2 GB which caused these errors:

  obj\content\content_browser.lib : fatal error LNK1107: invalid or
  corrupt file: cannot read at 0xEAE7739

msvs_shard is a way of breaking up a library to avoid this limitation.

This issue doesn't affect the GN builds (because they use a sourceset
concept instead of these huge static libraries).

TBR=creis@chromium.org
BUG=616946

Committed: https://crrev.com/c9dd766b9c61d5a4186ce8d3c1bbf830ad27b2f2
Cr-Commit-Position: refs/heads/master@{#398112}
==========

[commit-bot: I haz the power, 2016-06-06 20:36:11]

Patchset 1 (id:??) landed as
https://crrev.com/c9dd766b9c61d5a4186ce8d3c1bbf830ad27b2f2
Cr-Commit-Position: refs/heads/master@{#398112}