Issue 2046563012: mash: Move shelf menu code to //ash/common/shelf

Issue 2046563012: mash: Move shelf menu code to //ash/common/shelf (Closed)

Created:
4 years, 6 months ago by James Cook

Modified:
4 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, kalyank, sadrul

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

mash: Move shelf menu code to //ash/common/shelf It no longer has non-common dependencies. I'll TBR since it's a purely mechanical file move. BUG=615155 TEST=compiles TBR=sky@chromium.org Committed: https://crrev.com/bdbbc06a9ef355c904ccc62578ab1015e31aaf49 Cr-Commit-Position: refs/heads/master@{#398750}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -168 lines)			Patch
M	ash/ash.gyp	View	4 chunks	+3 lines, -3 lines	0 comments	Download
A +	ash/common/shelf/shelf_alignment_menu.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ash/common/shelf/shelf_alignment_menu.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	ash/common/shelf/shelf_menu_model.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
D	ash/shelf/shelf_alignment_menu.h	View	1 chunk	+0 lines, -45 lines	0 comments	Download
D	ash/shelf/shelf_alignment_menu.cc	View	1 chunk	+0 lines, -77 lines	0 comments	Download
D	ash/shelf/shelf_menu_model.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	ash/shelf/shelf_view.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	ash/shell/context_menu.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/sysui/context_menu_mus.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/sysui/shelf_delegate_mus.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/ash/launcher/launcher_application_menu_item_model.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/ash/launcher/launcher_context_menu.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046563012/1

4 years, 6 months ago (2016-06-09 00:03:06 UTC) #2

commit-bot: I haz the power

4 years, 6 months ago (2016-06-09 00:49:37 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bdbbc06a9ef355c904ccc62578ab1015e31aaf49
Cr-Commit-Position: refs/heads/master@{#398750}