Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: skia/public/interfaces/bitmap_skbitmap_struct_traits.h

Issue 2046563005: Add ArrayTraits<CArray<T>> utility template (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Yuzhu's comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: skia/public/interfaces/bitmap_skbitmap_struct_traits.h
diff --git a/skia/public/interfaces/bitmap_skbitmap_struct_traits.h b/skia/public/interfaces/bitmap_skbitmap_struct_traits.h
index fbd54114b80a5d87cb157d0411a5df4d4dd28836..91a51ff266f8de708a430dce524631a19c7a8982 100644
--- a/skia/public/interfaces/bitmap_skbitmap_struct_traits.h
+++ b/skia/public/interfaces/bitmap_skbitmap_struct_traits.h
@@ -12,22 +12,7 @@
namespace mojo {
// A buffer used to read pixel data directly from BitmapDataView to SkBitmap.
-struct BitmapBuffer {
- uint8_t* data = nullptr;
- size_t size = 0;
-};
-
-// ArrayTraits needed for ReadPixelData use with BitmapBuffer.
-template <>
-struct ArrayTraits<BitmapBuffer> {
- using Element = uint8_t;
- static size_t GetSize(const BitmapBuffer& b);
- static uint8_t* GetData(BitmapBuffer& b);
- static const uint8_t* GetData(const BitmapBuffer& b);
- static uint8_t& GetAt(BitmapBuffer& b, size_t i);
- static const uint8_t& GetAt(const BitmapBuffer& b, size_t i);
- static bool Resize(BitmapBuffer& b, size_t size);
-};
+using BitmapBuffer = CArray<uint8_t>;
// Struct traits to use SkBitmap for skia::mojom::Bitmap in Chrome C++ code.
template <>

Powered by Google App Engine
This is Rietveld 408576698