Add ArrayTraits<CArray<T>> utility template

Add ArrayTraits<CArray<T>> utility template

This CL adds a utility ArrayTraits class to read and write from and into a c array from StructTraits.

This CL also deletes duplicate code across various traits.

BUG=611802
TBR=ben@chromium.org, tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ea3c906a94710cbc68483e9c5d5cee88f5b1569a
Cr-Commit-Position: refs/heads/master@{#398634}

[Fady Samuel, 2016-06-07 21:19:28]

Description was changed from

==========
Add ArrayTraits<CArray<T>> utility template

BUG=
==========

to

==========
Add ArrayTraits<CArray<T>> utility template

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-06-07 21:33:23]

Description was changed from

==========
Add ArrayTraits<CArray<T>> utility template

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add ArrayTraits<CArray<T>> utility template

This CL adds a utility ArrayTraits class to read and write from and into a c
array from StructTraits.

This CL also deletes duplicate code across various traits.

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-06-07 21:33:34]

fsamuel@chromium.org changed reviewers:
+ yzshen@chromium.org

[yzshen1, 2016-06-07 22:29:29]

Thanks! Very glad to see this change.

https://codereview.chromium.org/2046563005/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/array_traits_carray.h (right):

https://codereview.chromium.org/2046563005/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/array_traits_carray.h:8: #include <vector>
No need to have this include.

https://codereview.chromium.org/2046563005/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/array_traits_carray.h:22: size_t max_size;
Does it make sense to:
- either making this const
- or removing it and making |size| an in/out kind of member?

[Fady Samuel, 2016-06-08 00:50:05]

fsamuel@chromium.org changed reviewers:
+ ben@chromium.org

[Fady Samuel, 2016-06-08 00:50:06]

PTAL Yuzhu! Once Yuzhu, is happy +ben@ for everything else! Thanks!

https://codereview.chromium.org/2046563005/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/array_traits_carray.h (right):

https://codereview.chromium.org/2046563005/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/array_traits_carray.h:8: #include <vector>
On 2016/06/07 22:29:29, yzshen1 wrote:
> No need to have this include.

Done.

https://codereview.chromium.org/2046563005/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/array_traits_carray.h:22: size_t max_size;
On 2016/06/07 22:29:29, yzshen1 wrote:
> Does it make sense to:
> - either making this const
> - or removing it and making |size| an in/out kind of member?

Made it const. I'd prefer not to have it in and out because I worry that it's
confusing and if Resize is called more than once, might fail.

[Fady Samuel, 2016-06-08 00:51:20]

PTAL

https://codereview.chromium.org/2046563005/diff/80001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/array_traits_carray.h (right):

https://codereview.chromium.org/2046563005/diff/80001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/array_traits_carray.h:28: static bool IsNull(const
CArray<T>& input) { return !input.data; }
Note, I need this for my cc::FilterOperation patch. matrix() (array<float, 20>)
is optional.

[Fady Samuel, 2016-06-08 01:38:08]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 01:38:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046563005/80001

[commit-bot: I haz the power, 2016-06-08 02:54:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 02:54:43]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2016-06-08 15:00:21]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 15:01:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046563005/100001

[yzshen1, 2016-06-08 16:09:17]

https://codereview.chromium.org/2046563005/diff/100001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/array_traits_carray.h (right):

https://codereview.chromium.org/2046563005/diff/100001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/array_traits_carray.h:26: static bool IsNull(const
CArray<T>& input) { return !input.data; }
SetToNull() is also needed. That means we either need to make |data| an in/out;
or add another field.

[commit-bot: I haz the power, 2016-06-08 16:23:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 16:23:56]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2016-06-08 16:49:23]

PTAL Yuzhu!

[yzshen1, 2016-06-08 16:55:21]

lgtm

[Fady Samuel, 2016-06-08 17:23:05]

Ben, I'm going to TBR you. Please let me know if you have any concerns if this
lands before you get to it.

[Fady Samuel, 2016-06-08 17:23:22]

Description was changed from

==========
Add ArrayTraits<CArray<T>> utility template

This CL adds a utility ArrayTraits class to read and write from and into a c
array from StructTraits.

This CL also deletes duplicate code across various traits.

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add ArrayTraits<CArray<T>> utility template

This CL adds a utility ArrayTraits class to read and write from and into a c
array from StructTraits.

This CL also deletes duplicate code across various traits.

BUG=611802
TBR=ben@chromium.org, tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-06-08 17:23:44]

fsamuel@chromium.org changed reviewers:
+ tsepez@chromium.org

[Fady Samuel, 2016-06-08 17:23:45]

+tsepez@ TBR'ing you too since this touches traits.

[Fady Samuel, 2016-06-08 17:23:52]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-06-08 17:24:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046563005/120001

[Tom Sepez, 2016-06-08 17:38:47]

lgtm

https://codereview.chromium.org/2046563005/diff/120001/gpu/ipc/common/mailbox...
File gpu/ipc/common/mailbox_struct_traits.cc (right):

https://codereview.chromium.org/2046563005/diff/120001/gpu/ipc/common/mailbox...
gpu/ipc/common/mailbox_struct_traits.cc:12: MailboxName mailbox_name =
{GL_MAILBOX_SIZE_CHROMIUM,
nit: can this be just

  return {GL_MAILBOX_SIZE_CHROMIUM,
          GL_MAILBOX_SIZE_CHROMIUM,
          const_cast<int8_t*>(&mailbox.name[0])};

Or does the compiler not have enough information to deduce the type?

https://codereview.chromium.org/2046563005/diff/120001/skia/public/interfaces...
File skia/public/interfaces/bitmap_skbitmap_struct_traits.cc (right):

https://codereview.chromium.org/2046563005/diff/120001/skia/public/interfaces...
skia/public/interfaces/bitmap_skbitmap_struct_traits.cc:156: BitmapBuffer
bitmap_buffer = {b.getSize(), b.getSize(),
nit: same here.

[Fady Samuel, 2016-06-08 17:47:11]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2016-06-08 17:48:03]

Thanks! That was a nice cleanup! CQ'ing!

https://codereview.chromium.org/2046563005/diff/120001/gpu/ipc/common/mailbox...
File gpu/ipc/common/mailbox_struct_traits.cc (right):

https://codereview.chromium.org/2046563005/diff/120001/gpu/ipc/common/mailbox...
gpu/ipc/common/mailbox_struct_traits.cc:12: MailboxName mailbox_name =
{GL_MAILBOX_SIZE_CHROMIUM,
On 2016/06/08 17:38:47, Tom Sepez wrote:
> nit: can this be just
> 
>   return {GL_MAILBOX_SIZE_CHROMIUM,
>           GL_MAILBOX_SIZE_CHROMIUM,
>           const_cast<int8_t*>(&mailbox.name[0])};
> 
> Or does the compiler not have enough information to deduce the type?

Done.

https://codereview.chromium.org/2046563005/diff/120001/skia/public/interfaces...
File skia/public/interfaces/bitmap_skbitmap_struct_traits.cc (right):

https://codereview.chromium.org/2046563005/diff/120001/skia/public/interfaces...
skia/public/interfaces/bitmap_skbitmap_struct_traits.cc:156: BitmapBuffer
bitmap_buffer = {b.getSize(), b.getSize(),
On 2016/06/08 17:38:47, Tom Sepez wrote:
> nit: same here.

Done.

[Fady Samuel, 2016-06-08 17:48:08]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-06-08 17:48:09]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2046563005/#ps140001
(title: "Addressed tsepez's comments")

[commit-bot: I haz the power, 2016-06-08 17:48:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046563005/140001

[commit-bot: I haz the power, 2016-06-08 19:16:06]

Description was changed from

==========
Add ArrayTraits<CArray<T>> utility template

This CL adds a utility ArrayTraits class to read and write from and into a c
array from StructTraits.

This CL also deletes duplicate code across various traits.

BUG=611802
TBR=ben@chromium.org, tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add ArrayTraits<CArray<T>> utility template

This CL adds a utility ArrayTraits class to read and write from and into a c
array from StructTraits.

This CL also deletes duplicate code across various traits.

BUG=611802
TBR=ben@chromium.org, tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-06-08 19:16:08]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-06-08 19:17:40]

Description was changed from

==========
Add ArrayTraits<CArray<T>> utility template

This CL adds a utility ArrayTraits class to read and write from and into a c
array from StructTraits.

This CL also deletes duplicate code across various traits.

BUG=611802
TBR=ben@chromium.org, tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add ArrayTraits<CArray<T>> utility template

This CL adds a utility ArrayTraits class to read and write from and into a c
array from StructTraits.

This CL also deletes duplicate code across various traits.

BUG=611802
TBR=ben@chromium.org, tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ea3c906a94710cbc68483e9c5d5cee88f5b1569a
Cr-Commit-Position: refs/heads/master@{#398634}
==========

[commit-bot: I haz the power, 2016-06-08 19:17:41]

Patchset 8 (id:??) landed as
https://crrev.com/ea3c906a94710cbc68483e9c5d5cee88f5b1569a
Cr-Commit-Position: refs/heads/master@{#398634}