Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2046523003: 💺 Pass --loader-base-dir in jinja_template to make webrtc happy (Closed)

Created:
4 years, 6 months ago by agrieve
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass --loader-base-dir in jinja_template to make webrtc happy Without this explicit flag, the base-dir ends up as //chromium/src within a webrtc checkout rather than //. BUG=webrtc:5956 Committed: https://crrev.com/9cdbc547091fcb196cc49720811af83510670e8f Cr-Commit-Position: refs/heads/master@{#398298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/config/android/rules.gni View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
agrieve
On 2016/06/07 01:00:36, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:kjellander@chromium.org
4 years, 6 months ago (2016-06-07 01:00:56 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046523003/1
4 years, 6 months ago (2016-06-07 01:02:08 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-07 02:43:13 UTC) #7
kjellander_chromium
lgtm
4 years, 6 months ago (2016-06-07 05:29:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046523003/1
4 years, 6 months ago (2016-06-07 13:59:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 14:34:57 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 14:37:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cdbc547091fcb196cc49720811af83510670e8f
Cr-Commit-Position: refs/heads/master@{#398298}

Powered by Google App Engine
This is Rietveld 408576698