Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2046493007: [Sync] Make chrome sync response compression as default (Closed)

Created:
4 years, 6 months ago by Gang Wu
Modified:
4 years, 6 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make chrome sync response compression as default BUG=509728 Committed: https://crrev.com/1bc923a2a0838269de64536cf62e51e63880d76e Cr-Commit-Position: refs/heads/master@{#398730}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M sync/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/http_bridge.cc View 1 3 chunks +0 lines, -15 lines 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 1 4 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Gang Wu
PTAL
4 years, 6 months ago (2016-06-07 23:53:13 UTC) #5
Nicolas Zea
lgtm
4 years, 6 months ago (2016-06-08 19:53:55 UTC) #6
Nicolas Zea
https://codereview.chromium.org/2046493007/diff/20001/sync/internal_api/http_bridge.cc File sync/internal_api/http_bridge.cc (right): https://codereview.chromium.org/2046493007/diff/20001/sync/internal_api/http_bridge.cc#newcode15 sync/internal_api/http_bridge.cc:15: #include "base/metrics/field_trial.h" nit: remove?
4 years, 6 months ago (2016-06-08 19:54:23 UTC) #7
Gang Wu
remove more unused codes. https://codereview.chromium.org/2046493007/diff/20001/sync/internal_api/http_bridge.cc File sync/internal_api/http_bridge.cc (right): https://codereview.chromium.org/2046493007/diff/20001/sync/internal_api/http_bridge.cc#newcode15 sync/internal_api/http_bridge.cc:15: #include "base/metrics/field_trial.h" On 2016/06/08 19:54:22, ...
4 years, 6 months ago (2016-06-08 22:23:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046493007/80001
4 years, 6 months ago (2016-06-08 22:36:31 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 6 months ago (2016-06-08 23:21:22 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 23:22:28 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1bc923a2a0838269de64536cf62e51e63880d76e
Cr-Commit-Position: refs/heads/master@{#398730}

Powered by Google App Engine
This is Rietveld 408576698