Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2046493006: Package map processing tests. (Closed)

Created:
4 years, 6 months ago by pquitslund
Modified:
4 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Package map processing tests. Follow-up from https://codereview.chromium.org/2043963004/, where a number of test cases were identified. In particular: > - What if the package map is empty? > - What if the package map doesn't have a package with an embedder file? > - What is there is no package with an ext? > - What if we don't find either one? > - What happens if one or both of those files are invalid? BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/df4ea535938fe2e967ebcb14ef4537ea92f836bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -9 lines) Patch
M pkg/analyzer/test/src/context/context_factory_test.dart View 3 chunks +90 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/context/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
4 years, 6 months ago (2016-06-07 21:19:33 UTC) #2
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-06-07 22:00:06 UTC) #3
pquitslund
4 years, 6 months ago (2016-06-07 22:04:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
df4ea535938fe2e967ebcb14ef4537ea92f836bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698