Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2046473002: media: Remove logMedia from WTFLogChannel (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
fs, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Remove logMedia from WTFLogChannel Removed logMedia from WTFLogChannel as all WTF_LOGs are replaced with DVLOGs in media modules. Few WTF_LOGs are still present in HTMLMediaElement.cpp and removed them as well in this CL. BUG=596522 Committed: https://crrev.com/9d88bc593d79030ed8c7dc8caf44d8b4a018b1b6 Cr-Commit-Position: refs/heads/master@{#398848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/Logging.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Logging.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Srirama
PTAL, when you are back.
4 years, 6 months ago (2016-06-06 11:10:21 UTC) #4
fs
LGTM, non-owner for platform/, so you'll need to find someone to stamp that (or wait ...
4 years, 6 months ago (2016-06-06 12:21:44 UTC) #5
Srirama
On 2016/06/06 12:21:44, fs (OoO) wrote: > LGTM, non-owner for platform/, so you'll need to ...
4 years, 6 months ago (2016-06-09 06:36:40 UTC) #6
foolip
lgtm
4 years, 6 months ago (2016-06-09 10:34:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046473002/1
4 years, 6 months ago (2016-06-09 10:34:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 12:05:58 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 12:07:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d88bc593d79030ed8c7dc8caf44d8b4a018b1b6
Cr-Commit-Position: refs/heads/master@{#398848}

Powered by Google App Engine
This is Rietveld 408576698