Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 2046463002: Remove WebFontsIntervention flag from fieldtrial testing config (Closed)

Created:
4 years, 6 months ago by Takashi Toyoshima
Modified:
4 years, 6 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebFontsIntervention flag from fieldtrial testing config The feature was already shipped, and there is no relevant trial on trunk source code. Note: This configuration looks wrong. Since the study used FeatureList API, it should have an enable_features field to enable it correctly. BUG=n/a Committed: https://crrev.com/eee7c4111f77d421e2d689315bb7f219b8ccbc49 Cr-Commit-Position: refs/heads/master@{#398136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Takashi Toyoshima
Can you take a look?
4 years, 6 months ago (2016-06-06 10:54:43 UTC) #2
Ilya Sherman
lgtm
4 years, 6 months ago (2016-06-06 18:15:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046463002/1
4 years, 6 months ago (2016-06-06 18:16:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 22:10:13 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 22:12:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eee7c4111f77d421e2d689315bb7f219b8ccbc49
Cr-Commit-Position: refs/heads/master@{#398136}

Powered by Google App Engine
This is Rietveld 408576698